Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix REPLACEME in changelog PR URLs #18561

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 4, 2018

These were mistakenly not replaced while landing the PRs.

/cc @BridgeAR

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@addaleax addaleax added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 4, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 4, 2018
@maclover7
Copy link
Contributor

@addaleax
Copy link
Member Author

addaleax commented Feb 4, 2018

Landed in 05e702d

@addaleax addaleax closed this Feb 4, 2018
@addaleax addaleax deleted the fix-replaceme-pr-url branch February 4, 2018 18:28
addaleax added a commit that referenced this pull request Feb 4, 2018
PR-URL: #18561
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@BridgeAR
Copy link
Member

BridgeAR commented Feb 4, 2018

@addaleax thanks a lot.

@MylesBorins
Copy link
Contributor

I set as don't land assuming that these changes are all semver major, please change labels if I am incorrect

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18561
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants