Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: add handle ref/unref stubs in rr mode #2274

Merged
merged 1 commit into from
Jul 30, 2015
Merged

cluster: add handle ref/unref stubs in rr mode #2274

merged 1 commit into from
Jul 30, 2015

Commits on Jul 30, 2015

  1. cluster: add handle ref/unref stubs in rr mode 

    Add ref() and unref() stub methods to the faux handle in round-robin
mode.  Fixes the following TypeError when calling `server.unref()` in
the worker:

    net.js:1521
        this._handle.unref();
                     ^
    TypeError: this._handle.unref is not a function
        at Server.unref (net.js:1521:18)

No actual reference counting is implemented.  It would effectively be
a no-op because the control channel would still keep the worker alive.

Fixes: nodejs#73
PR-URL: nodejs#2274
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @bnoordhuis
    bnoordhuis committed Jul 30, 2015
    Configuration menu
    Copy the full SHA
    fa98b97 View commit details
    Browse the repository at this point in the history