Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add test-all-suites to Makefile #25799

Closed
wants to merge 3 commits into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 29, 2019

There is currently no Makefile target that runs every test suite. This
adds one.

Didn't add it to vcbuild.bat because I'm not sure if * wildcard works the same way on Windows or not and I don't have Windows to test. Apparently 26 of the 46 targets in Makefile do not exist in vcbuild.bat so I suppose this is not a deal-breaker. But we can open a separate issue (and label it good-first-contribution) to have this added to vcbuild.bat. Or someone can add a commit to this branch to add it if they have Windows and can test their implementation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

There is currently no Makefile target that runs every test suite. This
adds one.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 29, 2019
@Trott
Copy link
Member Author

Trott commented Jan 29, 2019

@addaleax

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2019
@Trott
Copy link
Member Author

Trott commented Jan 30, 2019

@Trott
Copy link
Member Author

Trott commented Jan 31, 2019

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20477/

@Trott
Copy link
Member Author

Trott commented Jan 31, 2019

This could use one more review/approval. @nodejs/build-files

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release

test-all-valgrind: test-build
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind

.PHONY: test-all-suites
test-all-suites: test-build test-js-native-api test-node-api | bench-addons-build ## Run all test suites.
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT We don't need the test/*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[side note] Could we have a target that is not dependent on anything else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without test/*, it runs 2413 test for me locally. With it, it runs 2639 tests. I think it's because leaving off test/* means that test.py will skip the suites in its IGNORED_SUITES list.

@Trott
Copy link
Member Author

Trott commented Feb 1, 2019

Landed in e1aa943

@Trott Trott closed this Feb 1, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 1, 2019
There is currently no Makefile target that runs every test suite. This
adds one.

PR-URL: nodejs#25799
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 3, 2019
There is currently no Makefile target that runs every test suite. This
adds one.

PR-URL: #25799
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
@Trott Trott deleted the test-all branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants