Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: exclude benchmark code from coverage report #25841

Closed
wants to merge 1 commit into from
Closed

tools: exclude benchmark code from coverage report #25841

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 31, 2019

Refs: nodejs/build#1676 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2464/pipeline

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 31, 2019
@Trott
Copy link
Member Author

Trott commented Jan 31, 2019

@bcoe @nodejs/build-files

bcoe
bcoe approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Trott
Copy link
Member Author

Trott commented Jan 31, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20476/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 31, 2019
mhdawson
mhdawson approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Jan 31, 2019 •
edited
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20487/ ✅

@Trott
Copy link
Member Author

Trott commented Feb 1, 2019

Would like to fast-track since #25799 has landed. Added that to the daily coverage job but now it's going to report benchmark results again until this lands. Rather than roll it back, I'd prefer to get this in quickly. Please 👍 here to approve fast-tracking.

@refack @bcoe @cjihrig @mhdawson @richardlau

Rebased to fix merge conflict.

Post-rebase CI: https://ci.nodejs.org/job/node-test-pull-request/20532/

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 2, 2019
bcoe
bcoe approved these changes Feb 2, 2019
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Trott
Copy link
Member Author

Trott commented Feb 2, 2019

Re-running the Raspberry Pi's which were canceled: https://ci.nodejs.org/job/node-test-commit-arm-fanned/6185/

@Trott
Copy link
Member Author

Trott commented Feb 2, 2019

Landed in 8198ca0

@Trott Trott closed this Feb 2, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 2, 2019
@Trott
tools: exclude benchmark code from coverage report
8198ca0 
Refs: nodejs/build#1676 (comment)

PR-URL: nodejs#25841
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Feb 3, 2019
@Trott @addaleax
tools: exclude benchmark code from coverage report
f395728 
Refs: nodejs/build#1676 (comment)

PR-URL: #25841
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the coverage-fix branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@bcoe bcoe bcoe approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes