Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: edit Landing Pull Requests #26536

Closed
wants to merge 2 commits into from
Closed

doc: edit Landing Pull Requests #26536

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 8, 2019

Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: edit Landing Pull Requests
ac87744 
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2828/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 8, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Mar 9, 2019
vsemozhetbyt
vsemozhetbyt reviewed Mar 9, 2019
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
vsemozhetbyt
vsemozhetbyt reviewed Mar 9, 2019
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented Mar 11, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2857/

@Trott
Copy link
Member Author

Trott commented Mar 11, 2019

Landed in cc2c07c

@Trott Trott closed this Mar 11, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 11, 2019
@Trott
doc: edit Landing Pull Requests
cc2c07c 
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: nodejs#26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@Trott @BridgeAR
doc: edit Landing Pull Requests
e8c45ab 
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@Trott @BridgeAR
doc: edit Landing Pull Requests
119adf2 
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@Trott @BridgeAR
doc: edit Landing Pull Requests
76c22f8 
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@Trott @BethGriggs
doc: edit Landing Pull Requests
72f0efc 
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the landing-pull-requests branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@danbev danbev danbev approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@shisama shisama shisama approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @danbev @targos @cjihrig @BridgeAR @shisama @vsemozhetbyt