Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2019-03-14, Version 11.12.0 (Current) #26644

Merged
merged 156 commits into from
Mar 15, 2019
Merged

2019-03-14, Version 11.12.0 (Current) #26644

merged 156 commits into from
Mar 15, 2019

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Mar 13, 2019

Notable Changes

  • bootstrap:
    • Add experimental --frozen-intrinsics flag (Guy Bedford) #25685
  • build:
    • Enable v8's siphash for hash seed creation (Rod Vagg) #26367
  • deps:
    • Upgrade openssl to 1.1.1b (Sam Roberts) #26327
  • process:
    • Make process[Symbol.toStringTag] writable again (Ruben Bridgewater) #26488
  • repl:
    • Add util.inspect.replDefaults to customize the writer (Ruben Bridgewater) #26375
  • report:
    • Rename triggerReport() to writeReport() (Colin Ihrig) #26527

Commits

  • [142a92ffaf] - benchmark: refactor path benchmarks (Ruben Bridgewater) #26359
  • [52a0d76f32] - benchmark,doc,lib,test: capitalize comments (Ruben Bridgewater) #26483
  • [f79cf7067f] - benchmark,lib: add process.hrtime.bigint benchmark (Anna Henningsen) #26381
  • [3e54f90911] - (SEMVER-MINOR) bootstrap: experimental --frozen-intrinsics flag (Guy Bedford) #25685
  • [68bb1e9fd8] - buffer: do not affect memory after target for utf16 write (Anna Henningsen) #26432
  • [9b1cb9da57] - build: enable v8's siphash for hash seed creation (Rod Vagg) #26367
  • [b2e27a02b4] - Revert "build: silence cpp lint by default" (Refael Ackermann) #26358
  • [240de933f4] - build: indicate that configure has done something (Richard Lau) #26436
  • [02faa1a50c] - build,deps: less warnings from V8 (Refael Ackermann) #26405
  • [c2471538ef] - build,win: simplify new msbuild\_arg option (Refael Ackermann) #26431
  • [8c864deaa4] - child_process: fire close event from stdio (kohta ito) #22892
  • [cba23ed92a] - cluster: refactor empty for in round_robin_handle.js (gengjiawen) #26560
  • [2a3cca7ec5] - cluster: improve for-loop (gengjiawen) #26336
  • [b9787fd5f3] - crypto: check for invalid chacha20-poly1305 IVs (Sam Roberts) #26537
  • [991ea8add3] - crypto: simplify GetPublicOrPrivateKeyFromJs (Tobias Nießen) #26454
  • [7155aafbab] - crypto: don't call SSL_CTX_set_ciphersuites on boringssl (Jeremy Apthorp) #26365
  • [01e69f948d] - deps: v8, backport 2d08967 (Benjamin) #26413
  • [28dc54bc56] - deps: update OpenSSL upgrade process (Sam Roberts) #26378
  • [58957264a5] - deps: openssl-1.1.1b no longer packages .gitignore (Sam Roberts) #26327
  • [88079caffa] - deps: update archs files for OpenSSL-1.1.1b (Sam Roberts) #26327
  • [71c4d75c08] - deps: upgrade openssl sources to 1.1.1b (Sam Roberts) #26327
  • [dd95d072af] - Revert "deps: remove OpenSSL git and travis configuration" (Sam Roberts) #26327
  • [0fc975ddc2] - deps,tools: include SipHash in LICENSE (Rod Vagg) #26367
  • [b9cfaa3c65] - doc: fix misleading sentence in http.md (Luigi Pinca) #26465
  • [6f685706a0] - doc: fix typo in http2.md (TJKoury) #26616
  • [e2aaee0ffd] - doc: edit "Using git-node" section of Guide (Rich Trott) #26580
  • [667a4026e7] - doc: add version for http.createServer() options addition (Ben Swinburne) #25001
  • [fdad4d2673] - doc: document diverging MessagePort.onmessage handling (Anna Henningsen) #26487
  • [5ad9929d12] - doc: add inspector API example for heapdump (Sam Roberts) #26498
  • [76c22f8f6f] - doc: edit Landing Pull Requests (Rich Trott) #26536
  • [414ad11e2b] - doc: document fake ENOTFOUND as a system error (cjihrig) #26495
  • [7323ffb436] - doc: add decode() & encode() methods into querystring.md (ZYSzys) #23889
  • [931174fd54] - doc: remove tsc-review (Rich Trott) #26506
  • [124203758f] - doc: update partner communities link in releases.md (Beth Griggs) #26475
  • [693505b006] - doc: fix nits in writing-tests.md (Vse Mozhet Byt) #26543
  • [5897bf4621] - doc: edit "Involving the TSC" (Rich Trott) #26481
  • [e3d79550c7] - doc: add guidance on console output in tests (Sam Roberts) #26456
  • [2ee9a962d7] - doc: add caveat and tradeoff example to readline (Vse Mozhet Byt) #26472
  • [9945c28b20] - doc: standardize on End-of-Life capitalization (Rich Trott) #26442
  • [6cc559fbec] - doc: add missing https Agent maxCachedSessions (Nicolas Moteau) #26433
  • [ca2328d26a] - doc: edit deprecation section of Collaborator Guide (Rich Trott) #26419
  • [05b92c96a4] - doc: fix the example implementation of MemoryRetainer (Joyee Cheung) #26262
  • [8b8297d05b] - doc: clarify http.Agent constructor options (Luigi Pinca) #26412
  • [9299fb8856] - doc: update AUTHORS list (Anna Henningsen) #26383
  • [d2e9e526c5] - doc: hello addon example should return "world" (Geir Hauge) #26328
  • [7e40ce1e9f] - doc: fix nits in report docs (Vse Mozhet Byt) #26461
  • [e79f0c23ad] - doc: fix up N-API support matrix (Michael Dawson) #26377
  • [56adebf789] - domain: set .domain non-enumerable on resources (Jordan Harband) #26210
  • [8b0164aa26] - events: improve for-loop (gengjiawen) #26354
  • [83fba1ebf2] - events: onceWrapper returns target value (himself65) #25818
  • [16d908939d] - http: send connection: close when closing conn (Yann Hamon) #26467
  • [bf7a52b764] - http: improve for-loop readability in _http_outgoing.js (gengjiawen) #26408
  • [c661d8c608] - http: remove unused variable in _http_server.js (gengjiawen) #26407
  • [4886fbfbee] - http: check for existance in resetHeadersTimeoutOnReqEnd (Matteo Collina) #26402
  • [6adcc6f574] - http2: Http2ServerResponse.end() should always return self (Robert Nagy) #24346
  • [529b0c04cf] - http2: refactor deprecated method in core.js (gengjiawen) #26275
  • [4b6c653d4d] - https: add missing localPort while create socket (leeight) #24554
  • [6b004e0e02] - lib: refactor deprecated function in readline.js (gengjiawen) #26494
  • [f128008474] - lib: import TextEncoder and TextDecoder from internal/encoding (Joyee Cheung) #26547
  • [fe6c419503] - lib: migrate process.binding to internalBinding (Beni von Cheni) #24952
  • [9398d84735] - lib,src: remove usage of _externalStream (Anna Henningsen) #26510
  • [1fa5004e81] - lib,test: improve faulty assert usage detection (Ruben Bridgewater) #26569
  • [8e7204ed96] - n-api: improve performance creating strings (Anthony Tuininga) #26439
  • [c14aa07b94] - net: use kHandle symbol for accessing native handle (Anna Henningsen) #26491
  • [275a8f9316] - process: make Symbol.toStringTag writable (Ruben Bridgewater) #26488
  • [ceebbfb869] - process: add --pending-deprecation to process.binding() (Anna Henningsen) #26500
  • [1a0004d08e] - repl: eliminate var in function _memory (gengjiawen) #26496
  • [788c57bdc4] - repl: simplify regex expression (gengjiawen) #26496
  • [2101371a8a] - repl: remove redundant escape (gengjiawen) #26496
  • [a0b119182d] - (SEMVER-MINOR) repl: add replDefaults to customize the writer (Ruben Bridgewater) #26375
  • [74ab1aa5d1] - report: rename triggerReport() to writeReport() (cjihrig) #26527
  • [ac81fd202c] - report: fix stdout/stderr output formatting (cjihrig) #26522
  • [2be9e800f1] - report: warn on process.report object access (cjihrig) #26414
  • [9f446a1cf4] - report: refactor configuration management (cjihrig) #26414
  • [0abb724bbc] - report: support RUSAGE_SELF stats on Windows (cjihrig) #26406
  • [bc09d2f83d] - src: fix SplitString to ignore white spaces (himself65) #26545
  • [5cbd11294d] - src: de-lint header usage (Refael Ackermann) #26306
  • [9768ec4ec4] - src: remove unused variables (cjihrig) #26590
  • [8822df838b] - src: rename Init and Start overloads to something more distinctive (Joyee Cheung) #26499
  • [a99fb5419b] - src: apply clang-tidy various improvement (gengjiawen) #26470
  • [1d4fd218f2] - src: guard against calling Init() multiple times (Anna Henningsen) #26458
  • [989fcef680] - src: delete unused method SetTemplateMethod (gengjiawen) #26451
  • [efadb10085] - src: delete unused method SetTemplateMethodNoSideEffect (gengjiawen) #26451
  • [a11cf3054c] - src: delete unused variable in env.h (gengjiawen) #26451
  • [edc4af0e7d] - src: merge debug-only SealHandleScopes (Anna Henningsen) #26459
  • [12fb73963c] - src: cleanup in all return paths in node::Start (Gireesh Punathil) #26471
  • [d688b8a132] - src: remove templating from StreamBase (Jon Moss) #25142
  • [203fa63a2b] - src: remove redundant cast in util-inl.h (gengjiawen) #26410
  • [c7bd21cfff] - src: make parameter name const reference in method TriggerNodeReport (gengjiawen) #26397
  • [bb374d405b] - src: remove redundant call in inspector_io.cc (gengjiawen) #26427
  • [81c5382f86] - src: remove redundant cast in string_search.h (gengjiawen) #26426
  • [2a2a4e69dc] - src: remove unused function in cares_wrap.cc (gengjiawen) #26429
  • [e21fa83dcd] - src: fix wrong enum reference in node.cc (gengjiawen) #26430
  • [0d810b7ef0] - src: use the config binding to carry --no-browser-globals (Joyee Cheung) #26228
  • [88fb7712a8] - src: fix build when NODE_USE_V8_PLATFORM is not defined (Nitish Sakhawalkar) #26380
  • [654f4d4338] - src: remove unused variable in node_http2.cc (gengjiawen) #26395
  • [1d279ac269] - src: remove unused variable in node_native_module.cc (gengjiawen) #26411
  • [dc2119a955] - src: fix more extra-semi warnings (Jeremy Apthorp) #26340
  • [170e196205] - src: forbid handle allocations from Platform tasks (Anna Henningsen) #26376
  • [9c277c04ad] - src: allow running tasks without Environment (Anna Henningsen) #26376
  • [622048d539] - src: prefer to get Environment from Context (Anna Henningsen) #26376
  • [716ec00883] - src: refactor Environment::GetCurrent(isolate) usage (Anna Henningsen) #26376
  • [f99349d416] - src: fix if indent in node_http2.cc (gengjiawen) #26396
  • [b8abb81666] - src: remove unused struct in test_inspector_socket.cc (gengjiawen) #26284
  • [da457a56be] - src: remove unused namespace (Aymen Naghmouchi) #26318
  • [b45c22bc87] - src: use object to pass Environment to functions (Anna Henningsen) #26382
  • [61baa45581] - src: document DoWrite() usage expectations (Sam Roberts) #26339
  • [82a68cebe3] - stream: ensure writable.destroy() emits error once (Luigi Pinca) #26057
  • [9e82ee926a] - test: fix test case in test-http2-respond-file-304.js (gengjiawen) #26565
  • [13253a3d08] - test: use semicolon for clarity (gengjiawen) #26566
  • [adfbfc985c] - test: fix test by removing node-inspect/lib/_inspect (Ruben Bridgewater) #26619
  • [e1a55e76b4] - test: fix syntax error in test-dns-idna2008.js when failing (Refael Ackermann) #26570
  • [cccd3a3849] - test: fix compiler warning in test_string.c (Daniel Bevenius) #26539
  • [2c55282226] - test: mark test-worker-prof as flake on all platforms (Refael Ackermann) #26600
  • [0f8d8d6262] - test: cover triggerReport() failure case (cjihrig) #26524
  • [5a0ed0b0b5] - test: cover stdout/stderr usage in triggerReport() (cjihrig) #26522
  • [bf7836511d] - test: mark test-worker-prof as Flaky on ARM (Refael Ackermann) #26557
  • [d590a458a6] - test: rewrite ocsp test to run in parallel (Sam Roberts) #26460
  • [476dc7e612] - test: de-flake test-dns-idna2008.js (Refael Ackermann) #26473
  • [78c4dbdc20] - test: bump test-bootstrap-modules.js limit (Joyee Cheung) #26520
  • [153a29c1c3] - test: refactor test/report/test-report-signal.js (cjihrig) #26446
  • [71a4b24119] - test: remove usage of process.binding() (Anna Henningsen) #26304
  • [2b2471b0fd] - test: fix tests so they work in worker threads (Richard Lau) #26453
  • [a67fea52c4] - test: relax timer check in test-report-uv-handles.js (Richard Lau) #26434
  • [dbb7a029d5] - test: improve code coverage in timers (Juan José Arboleda) #26310
  • [e1aa5106a7] - test: remove flaky designation for test_threadsafe_function (Rich Trott) #26403
  • [143dbb3db8] - timers: remove dead code and simplify args check (Ruben Bridgewater) #26555
  • [1c8076ef58] - tools: fix cpplint.py header rules (Refael Ackermann) #26306
  • [a32c7492f2] - tools: update ESLint to 5.15.1 (cjihrig) #26447
  • [9d92887cde] - tools: update to mdast-util-to-hast v3.0.2 (Sam Ruby) #22140
  • [3e2e779dc9] - tools: update capitalized-comments rule (Ruben Bridgewater) #26483
  • [dcfdef5467] - tools: update generated lint-md.js (Refael Ackermann) #26441
  • [4835504d7c] - tools: update node-lint-md-cli-rollup version 2 (Refael Ackermann) #26441
  • [972a0f9f3e] - tools: use dmn@2.2.1 to remove unneeded files (Rich Trott) #26462
  • [9f1cc735ab] - tools: update dmn to 2.2.1 in update scripts (Rich Trott) #26462
  • [b879c1e2e1] - tools: fix test.py --shell (Yang Guo) #26449
  • [3b19cbfa3d] - tools: update remark-preset-lint-node to 1.5.0 (Rich Trott) #26442
  • [0a1537e4e6] - tools: add no-var lint rule for tools directory (shisama) #26398
  • [57198f2b82] - tools: replace var to let/const (Masashi Hirano) #26398
  • [55b830476a] - tools: add mailmap support for Co-authored-by tags (Anna Henningsen) #26383
  • [dc4258ad26] - tools: apply stricter linting to tools directory (Rich Trott) #26394
  • [580ae5672f] - tools: refactor tools JS code (Rich Trott) #26394
  • [d841a89e47] - tools: roll inspector_protocol to f67ec5 (Pavel Feldman) #26303
  • [c57510effa] - tools: rebuild lint-md.js (Rich Trott) #26393
  • [c2d12513f7] - tools: update node-lint-md-cli-rollup lockfile (Rich Trott) #26393
  • [5bdf71c8bf] - tools: update ESLint to 5.15.0 (cjihrig) #26391
  • [1de9e138aa] - url: require encodeStr from internal/querystring (ZYSzys) #26538
  • [3ad58f3e45] - win,build: update Windows build documentation (Jon Kunkee) #25995
  • [e8f4096be1] - win,build: scope NASM warning to only x64 and x86 (Jon Kunkee) #25995
  • [7e4592e83f] - win,build: add ARM64 sections to common.gypi (Jon Kunkee) #25995
  • [8e60193aef] - win,build: add ARM64 support to vcbuild.bat (Jon Kunkee) #25995
  • [d75cb919d0] - win,build: add arbitrary and binlog options (Jon Kunkee) #25994
  • [62801b9320] - worker: release native Worker object earlier (Anna Henningsen) #26542
  • [73370b4584] - worker: remove ERR\_CLOSED\_MESSAGE\_PORT (Anna Henningsen) #26487

cjihrig and others added 30 commits March 12, 2019 20:48
Update ESLint to 5.15.0

PR-URL: #26391
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This includes an update for chownr from 1.0.1 to 1.1.1, which means a
fix for the issue described in
isaacs/chownr#14. While not a
user-facing issue, it seems like a good idea to patch promptly anyway.

PR-URL: #26393
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Update lint-md.js from updated rollup modules.

PR-URL: #26393
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

PR-URL: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
Fixes: #25808

PR-URL: #26303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Clarify how it must behave for both synchronous and asynchronous
completion.

PR-URL: #26339
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* standardize on arrow functions for callbacks
* standaradize on trailing commas for multiline arrays

PR-URL: #26394
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Enable ESLint rules for trailing commas and arrow callbacks in tools
directory. These rules are also in place in the benchmark directory.

PR-URL: #26394
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: #23621 (comment)

PR-URL: #26403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
The support matrix was out of date. Update
with current status.

Fixes: #25801

PR-URL: #26377
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Use a `v8::Object` with an internal field, rather than a
`v8::External`.

On a `GetReturnValue().Set(Environment::GetCurrent(args) == nullptr)`
noop function, this benchmarks as a ~60 % speedup, as calls to
`obj->GetAlignedPointerFromInternalField()` can be inlined and
the field is stored with one level of indirection less.

This also makes breaking up some pieces of the `Environment` class
into per-native-binding data easier, if we want to pursue that path
in the future.

PR-URL: #26382
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
So far the benchmarks created a highly specialized function which
would inline exactly to the input. This changes it to provide a
more realistic view to actual input by changing the input on each
iteration. That prevents the function to be to specific.

It also reduces the number of iterations the benchmarks are run to
reduce the overall runtime. A microbenchmark should already show a
significant difference with lower iterations, otherwise the
significance for real world applications is only limited.

PR-URL: #26359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #26318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #26310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #26284
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #26275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #25818
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
In `_tls_wrap.js` while calling `socket.connect` the `localPort` was
missing, restore it.

PR-URL: #24554
Fixes: #24543
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #26396
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #26365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #26354
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
PR-URL: #26336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit adds support for the resourceUsage report section
on Windows by using uv_getrusage() instead of getrusage().

PR-URL: #26406
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This reverts commit f395a4a.

As of openssl-1.1.1b, the dot-files are no longer distributed, so this
is no longer necessary.

PR-URL: #26327
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This updates all sources in deps/openssl/openssl with openssl-1.1.1b.

PR-URL: #26327
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
`cd deps/openssl/config; make` updates all archs dependant files.

PR-URL: #26327
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
gengjiawen and others added 11 commits March 14, 2019 17:15
PR-URL: #26566
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #26560
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #26545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
The `setUnrefTimeout` function is never called with more arguments
than two. So quite some code was dead and never used. This removes
that code and simplifies the args check not to coerce objects to
booleans.

PR-URL: #26555
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Calling `response.end(data)` is not 100% equivalent to calling
`response.write(data)` followed by `response.end()`.

PR-URL: #26465
Fixes: #26005
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
PR-URL: #26494
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: #26569
Refs: #26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR
Copy link
Member Author

BridgeAR commented Mar 14, 2019

I just ran the CI without cc0ffc5 and the build passed. So I pushed that out of the release as well.

PTAL

(I do not run CITGM or V8-CI again as the should not be impacted by the removal and the latter it was green. CITGM seemed fine besides fastify and I reported that to fastify so they have a look at it).

@BridgeAR
Copy link
Member Author

@nodejs/releasers it would be nice to get a LG.

@BridgeAR
Copy link
Member Author

BridgeAR commented Mar 14, 2019

@BridgeAR
Copy link
Member Author

It is getting very late here and I do not feel comfortable releasing this without a LG. There were quite a few conflicts and multiple PRs that I had to back out again, so to me it feels like this release should get some extra care.

// cc @nodejs/releasers

@BridgeAR
Copy link
Member Author

@targos @BethGriggs thanks! Since we now have one more day, shall I pull in a few more PRs that landed in the meanwhile? There are especially a couple of semver-minor ones that could be interesting to get out as well.

Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    #25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527
@BridgeAR
Copy link
Member Author

CITGM looks good to me. There are some weird errors in watchify which seem like flaky tests to me: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1767/nodes=osx1011/testReport/junit/(root)/citgm/watchify_v3_11_1/

@BridgeAR BridgeAR merged commit 51d874c into v11.x Mar 15, 2019
BridgeAR added a commit to nodejs/nodejs.org that referenced this pull request Mar 15, 2019
BridgeAR added a commit to nodejs/nodejs.org that referenced this pull request Mar 15, 2019
@targos targos deleted the v11.12.0-proposal branch June 4, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.