[v11.x] test: fix test by removing node-inspect/lib/_inspect #26619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this file is loaded with Node.js build without ssl, it will load 'node-inspect/lib/internal/inspect_client' as well. Due to that two deprecation warnings will be emitted instead of one and the test fails. It should be safe to just test all other cases and to ignore this specific file.
richardlau
approved these changes
Mar 12, 2019
|
Fixes: #26480 FWIW I dug a little and the behaviour regressed in 11.10.0 by commit b280d90 (prior to that commit only one deprecation warning was emitted). |
|
I would like to fast track this. @ collaborators please +1 if you are fine with that. |
|
This PR is specifically for v11 and no backport @nodejs/releasers |
BethGriggs
approved these changes
Mar 13, 2019
targos
approved these changes
Mar 13, 2019
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
If this file is loaded with Node.js build without ssl, it will load 'node-inspect/lib/internal/inspect_client' as well. Due to that two deprecation warnings will be emitted instead of one and the test fails. It should be safe to just test all other cases and to ignore this specific file. PR-URL: #26619 Fixes: #26480 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 14, 2019
If this file is loaded with Node.js build without ssl, it will load 'node-inspect/lib/internal/inspect_client' as well. Due to that two deprecation warnings will be emitted instead of one and the test fails. It should be safe to just test all other cases and to ignore this specific file. PR-URL: nodejs#26619 Fixes: nodejs#26480 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
If this file is loaded with Node.js build without ssl, it will load 'node-inspect/lib/internal/inspect_client' as well. Due to that two deprecation warnings will be emitted instead of one and the test fails. It should be safe to just test all other cases and to ignore this specific file. PR-URL: #26619 Fixes: #26480 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
If this file is loaded with Node.js build without ssl, it will load 'node-inspect/lib/internal/inspect_client' as well. Due to that two deprecation warnings will be emitted instead of one and the test fails. It should be safe to just test all other cases and to ignore this specific file. PR-URL: #26619 Fixes: #26480 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this file is loaded with Node.js build without ssl, it will load
'node-inspect/lib/internal/inspect_client' as well. Due to that two
deprecation warnings will be emitted instead of one and the test
fails.
It should be safe to just test all other cases and to ignore this
specific file.
Fixes: #26480
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes