napi: reduce gc finalization stress #27085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
mhdawson
added
node-api
|
s/finaliation/finalization/ in commit message |
mhdawson
force-pushed
the
napi-fin-reduce-stress
branch
from
8961ff2
to
1bc8222
Compare
|
@mscdex thanks for catching that, fixed. |
bnoordhuis
reviewed
Apr 4, 2019
mhdawson
force-pushed
the
napi-fin-reduce-stress
branch
from
ad8201b
to
ad3012c
Compare
nodejs#24494 fixed a crash but resulted in increased stress on gc finalization. A leak was reported in nodejs#26667 which we are still investigating. As part of this investigation I realized we can optimize to reduce amount of deferred finalization. Regardless of the root cause of the leak this should be a good optimization. It also resolves the leak for the case being reported in nodejs#26667. The OP in 26667 has confirmed that he can still recreate the original problem that 24494 fixed and that the fix still works with this optimization
mhdawson
force-pushed
the
napi-fin-reduce-stress
branch
from
ad3012c
to
881efee
Compare
mhdawson
changed the title
bnoordhuis
approved these changes
Apr 7, 2019
mscdex
changed the title
cjihrig
approved these changes
Apr 7, 2019
jasnell
approved these changes
Apr 8, 2019
mhdawson
added
the
author ready
|
Landed in ff89670. |
danbev
pushed a commit
that referenced
this pull request
Apr 9, 2019
#24494 fixed a crash but resulted in increased stress on gc finalization. A leak was reported in #26667 which we are still investigating. As part of this investigation I realized we can optimize to reduce amount of deferred finalization. Regardless of the root cause of the leak this should be a good optimization. It also resolves the leak for the case being reported in #26667. The OP in 26667 has confirmed that he can still recreate the original problem that 24494 fixed and that the fix still works with this optimization PR-URL: #27085 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@danbev thanks for landing :) |
This was referenced Apr 23, 2019
|
@danbev could this please be backported to node10? |
Sorry I don't have time to open a backport PR against 10 this week, but I'll try to do so next week unless someone beats me to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24494 fixed a crash
but resulted in increased stress on gc finalization. A leak
was reported in #26667 which
we are still investigating. As part of this investigation, I
realized we can optimize to reduce the amount of deferred finalization.
Regardless of the root cause of the leak this should be a
good optimization. It also resolves the leak for the case being
reported in #26667. The OP in #26667 has confirmed that he can
still recreate the original problem that #24494 fixed and that
the fix still works with this optimization
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes