Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

napi: reduce gc finalization stress #27085

Closed
wants to merge 1 commit into from

Commits on Apr 5, 2019

  1. n-api: reduce gc finalization stress

    nodejs#24494 fixed a crash
    but resulted in increased stress on gc finalization. A leak
    was reported in nodejs#26667 which
    we are still investigating. As part of this investigation I
    realized we can optimize to reduce amount of deferred finalization.
    Regardless of the root cause of the leak this should be a
    good optimization. It also resolves the leak for the case being
    reported in nodejs#26667. The OP in 26667 has confirmed that he can
    still recreate the original problem that 24494 fixed and that
    the fix still works with this optimization
    mhdawson committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    881efee View commit details
    Browse the repository at this point in the history