[v10.x] deps: fix V8 compiler error with clang++-11 #33094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
v10.x
v8 engine
jasnell
approved these changes
Apr 27, 2020
addaleax
changed the title
addaleax
approved these changes
Apr 27, 2020
targos
approved these changes
Apr 27, 2020
|
Does this require a bump to V8 version |
Yes, in common.gypi |
|
Pushed bump to the patch level. |
|
https://ci.nodejs.org/job/node-test-commit-linux/34933/ failed on euid tests, hard to see how they are related. resumed again. |
Fixes: nodejs#33040 error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing] ParameterList result{{}, {}, context->VARARGS(), {}}; Occurs twice: ../../deps/v8/src/torque/ast-generator.cc:123:32: ../../deps/v8/src/torque/ast-generator.cc:144:32:
richardlau
force-pushed
the
fix-narrow-to-bool
branch
from
05d5d52
to
48a7688
Compare
richardlau
approved these changes
Jul 1, 2020
richardlau
pushed a commit
that referenced
this pull request
Jul 1, 2020
Fixes: #33040 error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing] ParameterList result{{}, {}, context->VARARGS(), {}}; Occurs twice: ../../deps/v8/src/torque/ast-generator.cc:123:32: ../../deps/v8/src/torque/ast-generator.cc:144:32: PR-URL: #33094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in 89a306b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33040
Occurs twice:
../../deps/v8/src/torque/ast-generator.cc:123:32:
../../deps/v8/src/torque/ast-generator.cc:144:32:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes