Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] deps: fix V8 compiler error with clang++-11 #33094

Closed
wants to merge 1 commit into from
Closed

[v10.x] deps: fix V8 compiler error with clang++-11 #33094

wants to merge 1 commit into from

Commits on Jul 1, 2020

  1. deps: fix V8 compiler error with clang++-11 

    Fixes: nodejs#33040

		  error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to 'bool'
			  in initializer list [-Wc++11-narrowing]
			ParameterList result{{}, {}, context->VARARGS(), {}};

Occurs twice:
		../../deps/v8/src/torque/ast-generator.cc:123:32:
		../../deps/v8/src/torque/ast-generator.cc:144:32:
    @sam-github @richardlau
    sam-github authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    48a7688 View commit details
    Browse the repository at this point in the history