Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.15.5 proposal #37074

Merged
merged 10 commits into from
Feb 9, 2021
Merged

v14.15.5 proposal #37074

merged 10 commits into from
Feb 9, 2021

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Jan 26, 2021

2021-02-09, Version 14.15.5 'Fermium' (LTS), @BethGriggs

Notable Changes

  • deps:
    • upgrade npm to 6.14.11 (Ruy Adorno) #37173
    • V8: backport dfcf1e86fac0 (Michaël Zasso) #37245
  • stream,zlib: do not use _stream_* anymore (Matteo Collina) #36618

Commits

  • [20b1e6c802] - deps: V8: backport dfcf1e86fac0 (Michaël Zasso) #37245
  • [408c7a65f3] - deps: upgrade npm to 6.14.11 (Ruy Adorno) #37173
  • [017eed665b] - http: do not loop over prototype in Agent (Michaël Zasso) #36410
  • [25a3204fe2] - http: don't cork .end when not needed (Dimitris Halatsis) #36633
  • [2a1e4e9244] - stream: accept iterable as a valid first argument (ZiJian Liu) #36479
  • [9ff73fcdbe] - stream,zlib: do not use _stream_* anymore (Matteo Collina) #36618
  • [c03cddb46f] - test: http complete response after socket double end (Dimitris Halatsis) #36633
  • [f206505e9d] - util: fix instanceof checks with null prototypes during inspection (Ruben Bridgewater) #36178
  • [2f7944b18b] - util: fix module prefixes during inspection (Ruben Bridgewater) #36178

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. v14.x labels Jan 26, 2021
BethGriggs added a commit that referenced this pull request Jan 26, 2021
Notable changes:

- **deps**: upgrade npm to 6.14.11 (Darcy Clarke)
  [#36838](#36838)
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  [#36618](#36618)

PR-URL: #37074
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 26, 2021

@BethGriggs
Copy link
Member Author

cc: @nodejs/streams as there are a number of streams bug fixes going out in this release.

@BethGriggs
Copy link
Member Author

Delayed by a couple of CITGM reruns. Will update the changelog dates to tomorrow and aim to promote in the morning.

BethGriggs added a commit that referenced this pull request Jan 27, 2021
Notable changes:

- **deps**: upgrade npm to 6.14.11 (Darcy Clarke)
  [#36838](#36838)
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  [#36618](#36618)

PR-URL: #37074
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

let me know if there is anything in those CITGM I need to take a look for streams.

@BethGriggs
Copy link
Member Author

BethGriggs commented Jan 27, 2021

CITGM is very flaky on both v14.x and v14.15.5 (after several reruns).

┌────────────────────────┬─────────────────────────┬─────────────────┬────────────────────┐
│        (index)         │            0            │        1        │         2          │
├────────────────────────┼─────────────────────────┼─────────────────┼────────────────────┤
│     centos7-ppcle      │   'ember-cli-v3.24.0'   │ 'semver-v7.3.4' │ 'socket.io-v3.1.0' │
│        osx1015         │    'fastify-v3.11.0'    │                 │                    │
│     ubuntu1804-64      │                         │                 │                    │
│ fedora-last-latest-x64 │ 'torrent-stream-v1.2.1' │                 │                    │
│      rhel7-s390x       │ 'torrent-stream-v1.2.1' │                 │                    │
│     ubuntu1604-64      │    'winston-v3.3.3'     │                 │                    │
│       win-vs2017       │     'rewire-v5.0.0'     │                 │                    │
│   fedora-latest-x64    │                         │                 │                    │
│        osx1014         │                         │                 │                    │
└────────────────────────┴─────────────────────────┴─────────────────┴────────────────────┘

Summary:

  • centos7-ppcle failures are known.
  • osx1015 | fastify is a timeout, which I think we've seen before. The osx machines timeout a lot in CITGM too. Passed locally.
  • torrent-stream is another familiar flake.
  • ubuntu1604-64 | winston flake disappeared on rerun.
  • win-vs2017 | rewire - this one seems new but it's not obvious to me whether it's related:
 1) rewire
        should work like require():
      Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\Users\ADMINI~1\AppData\Local\Temp\448829c9-552d-4523-93e0-c42708400ee7\rewire\test\rewire.test.js)
       at processImmediate (internal/timers.js:461:21)

Edit: rewire seems okay on no-build reruns on the rc.0 - https://ci.nodejs.org/job/citgm-smoker-nobuild/nodes=win10-vs2019/1021/console

@BethGriggs
Copy link
Member Author

Just doing my final testing before release, and I have just noticed npm is reporting 6.14.10 rather than 6.14.11. I think the deps/npm/package.json bump may have been missed in #36838.

@nodejs/npm / @MylesBorins thoughts on how to proceed? Reland #36838 with the version updated to 6.14.11?

I think v10.23.2 might have gone out yesterday with the content of npm 6.14.11 but reports npm 6.14.10.

@MylesBorins
Copy link
Contributor

@BethGriggs it looks like there may have been something that went awry with the upgrade commit.

npm/cli@ef5b0d3

The release commit definitely bumped the version number, and the published version of the package has the right version. We could delay and get a fixed version of the update commit for you. what do you think?

@BethGriggs
Copy link
Member Author

We could delay and get a fixed version of the update commit for you. what do you think?

@MylesBorins, sure, happy to delay this one to patch up the commit. (Also to be updated on v12.x-staging)

I'm not sure on the best approach for v10.23.2 though

@MylesBorins
Copy link
Contributor

@BethGriggs I think we need to see how big the diff is when we get an updated patch.

Lxxyx and others added 4 commits January 28, 2021 17:56
Fixes: #36437

PR-URL: #36479
Backport-PR-URL: #36831
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36633
Backport-PR-URL: #36940
Fixes: #36620
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
PR-URL: #36633
Backport-PR-URL: #36940
Fixes: #36620
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
PR-URL: #36618
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
ruyadorno and others added 3 commits February 4, 2021 11:47
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: #37100
PR-URL: #36178
Fixes: #35730
Fixes: #36151
Refs: #35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: #37100
PR-URL: #36178
Fixes: #35730
Fixes: #36151
Refs: #35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 5, 2021
Notable changes:

- **deps**: upgrade npm to 6.14.11 (Ruy Adorno)
  (#37173)
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
@nodejs-github-bot
Copy link
Collaborator

Original commit message:

    [wasm] PostMessage of Memory.buffer should throw

    PostMessage of an ArrayBuffer that is not detachable should result
    in a DataCloneError.

    Bug: chromium:1170176, chromium:961059
    Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72415}

Refs: v8/v8@dfcf1e8

PR-URL: #37245
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 8, 2021
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 8, 2021

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

targos and others added 2 commits February 8, 2021 17:27
Fixes: #36364

PR-URL: #36410
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
@BethGriggs
Copy link
Member Author

BethGriggs commented Feb 9, 2021

CITGM on v14.15.5 looks okay to me.

Pino is failing on all platforms due to a lint failure, which is being addressed as part of pinojs/pino#961 (cc @mcollina)

@mcollina
Copy link
Member

mcollina commented Feb 9, 2021

thanks, sorry about this. I'll fix asap.

@BethGriggs
Copy link
Member Author

BethGriggs added a commit that referenced this pull request Feb 9, 2021
@BethGriggs BethGriggs merged commit 9fff0d3 into v14.x Feb 9, 2021
BethGriggs added a commit that referenced this pull request Feb 9, 2021
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Feb 9, 2021
@BethGriggs BethGriggs deleted the v14.15.5-proposal branch February 9, 2021 16:59
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Feb 9, 2021
@targos targos added the release Issues and PRs related to Node.js releases. label Apr 11, 2021
@targos targos removed npm Issues and PRs related to the npm client dependency or the npm registry. meta Issues and PRs related to the general management of the project. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants