streams: update .readable/.writable to false #4083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These properties were initially used to determine stream status back in node v0.8 and earlier. Since streams2 however, these properties were *always* true, which can be misleading for example if you are trying to immediately determine whether a Writable stream is still writable or not (to avoid a "write after end" exception).
|
CI is all green. @chrisdickinson I've replaced the additional conditional used in |
|
LGTM! |
mscdex
added a commit
that referenced
this pull request
Dec 2, 2015
These properties were initially used to determine stream status back in node v0.8 and earlier. Since streams2 however, these properties were *always* true, which can be misleading for example if you are trying to immediately determine whether a Writable stream is still writable or not (to avoid a "write after end" exception). PR-URL: #4083 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
|
Landed in cc0342a. |
mscdex
added a commit
that referenced
this pull request
Dec 5, 2015
These properties were initially used to determine stream status back in node v0.8 and earlier. Since streams2 however, these properties were *always* true, which can be misleading for example if you are trying to immediately determine whether a Writable stream is still writable or not (to avoid a "write after end" exception). PR-URL: #4083 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
This was referenced Dec 8, 2015
Closed
|
@mscdex ... how would you rate the semver'iness of this change? Should this go into v4? |
|
Marking this as lts-watch for v4 but please do not land in |
|
@jasnell I would say no for v4 as it's more like a semver-major since it changes property values of existing properties (for readables it sets |
MylesBorins
added
semver-major
|
adding semver-major tag and removing LTS watch. Please feel free to update if I was incorrect in doing so edit: if we do add it back to LTS we need to add the tag back to #4141 as well |
Closed
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
These properties were initially used to determine stream status back in node v0.8 and earlier. Since streams2 however, these properties were *always* true, which can be misleading for example if you are trying to immediately determine whether a Writable stream is still writable or not (to avoid a "write after end" exception). PR-URL: nodejs#4083 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These properties were initially used to determine stream status back in node v0.8 and earlier. Since streams2 however, these properties were always true, which can be misleading for example if you are trying to immediately determine whether a Writable stream is still writable or not (to avoid a "write after
end" exception).
This is #1217 targeting the master branch and with a couple of minor changes to fix a lint error and to help address a concern about
.on().