Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: be less eager with readable flag #4141

Closed
wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Dec 3, 2015

As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in child_process.

This commit fixes those failures by making readable streams less eager in setting their readable flag on EOF.

Fixes: #4125

As of 34b535f, test-child-process-flush-stdio was failing
on CentOS 5 systems in CI due to the change in stream state
checking in `child_process`. This commit fixes those failures
by making readable streams less eager in setting their readable
flag on EOF.

Fixes: nodejs#4125
@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Dec 3, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Dec 3, 2015

LGTM if the CI is happy.

@jasnell
Copy link
Member

jasnell commented Dec 4, 2015

LGTM. Is this a big enough change that we'd want to avoid it in LTS?

@cjihrig
Copy link
Contributor

cjihrig commented Dec 4, 2015

@jasnell This is backing out part of a change that just landed within the past couple days. The original change might not have even made it into LTS yet (#4083).

@jasnell
Copy link
Member

jasnell commented Dec 4, 2015

+1 gotcha

@mscdex
Copy link
Contributor Author

mscdex commented Dec 4, 2015

CI is all green except some unrelated Windows failures.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 4, 2015

Running the CI again since Windows wasn't working the last time, and I noticed the relevant test failing on Windows.

https://ci.nodejs.org/job/node-test-pull-request/920/

@cjihrig
Copy link
Contributor

cjihrig commented Dec 4, 2015

A couple failures on Windows, but unrelated to this. Reiterating my LGTM

mscdex added a commit that referenced this pull request Dec 4, 2015
As of 34b535f, test-child-process-flush-stdio was failing
on CentOS 5 systems in CI due to the change in stream state
checking in `child_process`. This commit fixes those failures
by making readable streams less eager in setting their readable
flag on EOF.

Fixes: #4125
PR-URL: #4141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex
Copy link
Contributor Author

mscdex commented Dec 4, 2015

Landed in 2922188.

@mscdex mscdex closed this Dec 4, 2015
mscdex added a commit that referenced this pull request Dec 5, 2015
As of 34b535f, test-child-process-flush-stdio was failing
on CentOS 5 systems in CI due to the change in stream state
checking in `child_process`. This commit fixes those failures
by making readable streams less eager in setting their readable
flag on EOF.

Fixes: #4125
PR-URL: #4141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
@mscdex mscdex deleted the fix-readable-writable-regress branch December 17, 2015 17:58
@jasnell
Copy link
Member

jasnell commented Dec 17, 2015

Marking this lts-watch for now. It should land in v4.x-staging only if #4083 also lands

@MylesBorins
Copy link
Contributor

Removing LTS tag as #4083 is currently not on LTS watch and labelled semver major

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
As of 34b535f, test-child-process-flush-stdio was failing
on CentOS 5 systems in CI due to the change in stream state
checking in `child_process`. This commit fixes those failures
by making readable streams less eager in setting their readable
flag on EOF.

Fixes: nodejs#4125
PR-URL: nodejs#4141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test: test-child-process-flush-stdio
5 participants