doc: copyedit releases.md #4384
Conversation
|
LGTM |
|
|
||
| **b.** Log in to the server via SSH and check for releases that can be promoted, along with the list of artifacts. It will use the `dist-promotable` command on the server to find these. You will be asked, for each promotable release, whether you want to proceed. If there is more than one release to promote (there shouldn't be), be sure to only promote the release you are responsible for. | ||
|
|
||
| **c.** Log in to the server via SSH and run the promote script for the given release. The command on the server will be similar to: `dist-promote vx.y.z`. After this step, the release artifacts will be available for download and a SHASUMS256.txt file will be present. The release will still be unsigned, however. | ||
|
|
||
| **d.** Download SHASUMS256.txt to your computer using SCP into a temporary directory. | ||
| **d.** Use SCP to download SHASUMS256.txt to a temporary directory on your computer. |
There was a problem hiding this comment.
In general, I believe SCP is used for the protocol and scp for the command, similar to SSH vs. ssh. I'm fine with either here. No strong feelings either way.
There was a problem hiding this comment.
the intention was for it to refer to the command, if you do it as scp it should be clear
There was a problem hiding this comment.
OK, SCP -> scp fixup pushed.
|
LGTM |
1 similar comment
|
LGTM |
|
Changes lgtm, thanks for the effort here @Trott. The doc is still out of date though, I'd love to go through and update it but I'm not sure I'll be able to find the time for a while. If any of the @nodejs/release team who have done a release recently want to have a go it'd be greatly appreciated. There are some things that stand out immediately:
I'm sure there are other things. |
|
@rvagg Safe for me to interpret your comment as a wish list of updates you'd like to see someone do soon if someone knowledgable can get to it, but no reason to refrain from merging the changes that are here at this time? |
|
@Trott yes, that's correct, this lgtm as is for a simple copyedit, great job. |
PR-URL: nodejs#4384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in b094402 |
PR-URL: #4384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#4384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #4384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#4384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
No description provided.