Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: bring releases.md up to date #4540

Closed
wants to merge 1 commit into from
Closed

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 5, 2016

This commit brings the release procedure documentation up to date. I tried to consolidate the material in the existing releases.md with #3254 and #4384 (comment).

Refs: #3254
R= @nodejs/release

@jasnell jasnell added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Jan 5, 2016
```

### 4. Update _src/node_version.h_
The release type should be either Stable, LTS, or Maintenance, depending on the type of release being produced.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should likely note that only the LTS WG can cut LTS releases and that there is a slightly modified process that uses the various -staging branches

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell since the audience for this document is the release and LTS team members, and I'm not totally up to speed on the LTS release process, would you be OK with adding the LTS specific info in a subsequent PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, not a problem!

@jasnell
Copy link
Member

jasnell commented Jan 5, 2016

Only performed a cursory look through but generally LGTM

cjihrig added a commit that referenced this pull request Jan 6, 2016
Refs: #3254
PR-URL: #4540
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 6, 2016

Thanks for the review. Landed in f1653cc.

@cjihrig cjihrig closed this Jan 6, 2016
@cjihrig cjihrig deleted the releases branch January 6, 2016 19:23
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
Refs: #3254
PR-URL: #4540
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 11, 2016
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
Refs: #3254
PR-URL: #4540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
Refs: #3254
PR-URL: #4540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
Refs: #3254
PR-URL: #4540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
Refs: #3254
PR-URL: #4540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Refs: #3254
PR-URL: #4540
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Refs: nodejs#3254
PR-URL: nodejs#4540
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants