Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: allow http.OutgoingMessage to be used in Writable.toWeb() #45642

Merged
merged 5 commits into from
Dec 10, 2022
Merged

lib: allow http.OutgoingMessage to be used in Writable.toWeb() #45642

merged 5 commits into from
Dec 10, 2022

Commits on Nov 28, 2022

  1. lib: allow Writeable.toWeb() to work on http.Outgoing message 

    Attempted to fix the issue by watering down the condition being
checked in internal/streams/utils isWritableNodeStream utility

Fixes: nodejs#44188
    @debadree25
    debadree25 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    093aa39 View commit details
    Browse the repository at this point in the history

  2. test: added test for checking if ServerResponse works or not similar … 

    …to the one mentioned in the issue
    @debadree25
    debadree25 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1c73b45 View commit details
    Browse the repository at this point in the history

  3. test: fixed linting and comments issues

    @debadree25
    debadree25 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6a9724f View commit details
    Browse the repository at this point in the history

  4. test: further update the test to ping the server

    @debadree25
    debadree25 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6e98157 View commit details
    Browse the repository at this point in the history

  5. lib: fix duplexes causing issue

    @debadree25
    debadree25 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    190611b View commit details
    Browse the repository at this point in the history