http.ServerResponse is not an instance of stream.Writable?

[sosoba]

Version

18.7.0

Platform

Microsoft Windows NT 10.0.19044.0 x64

Subsystem

stream

What steps will reproduce the bug?

import { createServer } from 'node:http';
import { Writable } from 'node:stream';
import { once } from 'node:events';

const server = createServer(async (req, nodeStreamResponse) => {
  const webStreamResponse = Writable.toWeb(nodeStreamResponse);
});
server.listen({ port: 8080 });
await once(server, 'listening');
await fetch('http://localhost:8080');

How often does it reproduce? Is there a required condition?

Always.

What is the expected behavior?

According to the documentation:

Class: http.ServerResponse extends http.OutgoingMessage
Class: http.OutgoingMessage extends Stream

This means that ServerResponse fulfilling the contract Writable.toWeb.

What do you see instead?

TypeError [ERR_INVALID_ARG_TYPE]: The "streamWritable" argument must be an stream.Writable. Received an instance of ServerResponse
    at new NodeError (node:internal/errors:387:5)
    at Object.newWritableStreamFromStreamWritable (node:internal/webstreams/adapters:99:11)
    at Writable.toWeb (node:internal/streams/writable:926:27)  

Additional information

Maybe this condition:

if (typeof streamWritable?._writableState !== 'object') {

is too heavy?

[daeyeon]

http.ServerResponse is not an instance of stream.Writable?

Throwing an error here seems to be an expected behavior since http.ServerResponse is an instance of Stream, not stream.Writable. Is this issue a feature request for the following?

stream.Writable.toWeb(stream : <stream.Writable>|<http.OutgoingMessage>)

[sosoba]

It seems that the bug is on @types/node

class OutgoingMessage extends stream.Writable {

Of course, the @daeyeon proposition is successful.

stream.Writable.toWeb(stream : <stream.Writable>|<http.OutgoingMessage>)

[ronag]

toWeb should work on OutgoingMessage.

[daltonna]

Has anyone claimed this issue? I haven't contributed before but I think this would be a good first issue for me as I have some ideas on a fix.

[AlexKliger]

Was this issue already assigned? If not, I'd like to try and solve it. Thanks.

[cola119]

go for it :)

[zeazad-hub]

Hey, is this issue still open, because I would like to work on it as my first issue.

[zeazad-hub]

Hello, I found out what was going wrong. Our outgoing message defined here does not extend stream.writable. The probelm is that stream.writable has a writable attribute that behaves differently from the OutgoingMessage writabel attribute and this causes test/parallel/test-http-writable-true-after-close.js to fail because it is not writable after it is destroyed. I was wondering if OutgoingMessage.writable should be true when OutgoingMessage.destroyed is true (like the test checks for) or should OutgoingMessage.writable be false when it gets destroyed?

[daeyeon]

@zeazad-hub FWIW, there seems to be a performance issue when trying OutgoingMessage inheriting stream.Writable.