Fixed OutgoingMessage so that it inherits from stream.Writable instead of stream #45834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of stream http.OutgoingMessage is supposed to be an instance of stream.Writable, so I set the prototype of OutgoingMessage equal to the Writable prototype and I called the Writable consrtuctor at the end of the constructor for OutgoingMessage. I made sure to override any methods and prpoperties in Writable that were already defined in OutgoingMessage in order to not interfere with the current behavior of OutgoingMessage. Fixes: nodejs#44188
… instead of stream http.OutgoingMessage is supposed to be an instance of stream.Writable, so I set the prototype of OutgoingMessage equal to the Writable prototype and I called the Writable consrtuctor at the end of the constructor for OutgoingMessage. I made sure to override any methods and prpoperties in Writable that were already defined in OutgoingMessage in order to not interfere with the current behavior of OutgoingMessage. Fixes: nodejs#44188
I accidentally left a script.sh file that copied all of the test files into a different directory in a previous commit. I did not end up using the script.sh and have now removed it from the repo. Fixes: nodejs#44188
|
Review requested:
|
nodejs-github-bot
added
http
mscdex
reviewed
Dec 12, 2022
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I think you forgot to remove this file
mscdex
reviewed
Dec 12, 2022
| @@ -53,6 +53,7 @@ const { | |||
| getHighWaterMark, | |||
| getDefaultHighWaterMark | |||
| } = require('internal/streams/state'); | |||
|
|
|||
There was a problem hiding this comment.
These newline only file changes should be removed (including the one in the test file).
mscdex
reviewed
Dec 12, 2022
| assert.strictEqual(isWritable, true); | ||
|
|
||
|
|
||
| const b = typeof nodeStreamResponse?._writableState |
There was a problem hiding this comment.
This and other lines won't pass the linter. Make sure you run make test locally to make sure all other tests pass in addition to the linting.
|
I think an immediate concern here is about compatibility with userland. At the very least a citgm will be needed and even then I'd be very wary of making a change like this. |
mscdex
added
needs-citgm
|
We have tried to do this multiple times in the past but the performance regression was significant. So unless V8 has implemented some magic since then I don't think we can do this. |
mcollina
requested changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http: fixed OutgoingMessage so that it inherits from stream.Writable instead of stream
http.OutgoingMessage is supposed to be an instance of stream.Writable, so I set
the prototype of OutgoingMessage equal to the Writable prototype and I called
the Writable consrtuctor at the end of the constructor for OutgoingMessage. I
made sure to override any methods and prpoperties in Writable that were
already defined in OutgoingMessage in order to not interfere with the
current behavior of OutgoingMessage. Note that I have recently
been told that this change does lead to performance issues with http.OutgoingMessage.
Fixes: #44188