Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: backport 8d00c2c from v8 upstream #5577

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Conversation

bnoordhuis
Copy link
Member

Original commit message:

Unbreak --gdbjit for embedders.

Embedders don't use d8.cc.  Move gdbjit initialization to api.cc.

Review URL: https://codereview.chromium.org/1710253002

Fixes: #2076

R=@ofrobots?

CI: https://ci.nodejs.org/job/node-test-pull-request/1871/

@bnoordhuis bnoordhuis added the v8 engine Issues and PRs related to the V8 dependency. label Mar 6, 2016
@bnoordhuis
Copy link
Member Author

/cc @eljefedelrodeodeljefe

@eljefedelrodeodeljefe
Copy link
Contributor

Did you really mean me, or is this some kind of magic where you knew I was currently reading it up in the v8 soures? 💯

@bnoordhuis
Copy link
Member Author

I'm a mind reader.

(Also, a v8-users reader.)

@eljefedelrodeodeljefe
Copy link
Contributor

:-)

Should be working now as expected. Verified it with lldb:

./configure --debug --gdb --xcode
make -j8
lldb -- ./node --perf-basic-prof --gdbjit console-test.js
(lldb) breakpoint set -name __jit_debug_register_code
(lldb) run

@jasnell
Copy link
Member

jasnell commented Mar 22, 2016

@bnoordhuis ... is this suitable for v4?

@ofrobots
Copy link
Contributor

LGTM. Sorry for the delay in reviewing – this got buried in my inbox.

@jasnell This is appropriate for backporting to LTS.

@jasnell
Copy link
Member

jasnell commented Mar 22, 2016

@ofrobots ... thank you!

Original commit message:

    Unbreak --gdbjit for embedders.

    Embedders don't use d8.cc.  Move gdbjit initialization to api.cc.

    Review URL: https://codereview.chromium.org/1710253002

Fixes: nodejs#2076
PR-URL: nodejs#5577
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@bnoordhuis bnoordhuis closed this Mar 23, 2016
@bnoordhuis bnoordhuis deleted the fix2076 branch March 23, 2016 08:50
@bnoordhuis bnoordhuis merged commit fb51c39 into nodejs:master Mar 23, 2016
evanlucas pushed a commit that referenced this pull request Mar 30, 2016
Original commit message:

    Unbreak --gdbjit for embedders.

    Embedders don't use d8.cc.  Move gdbjit initialization to api.cc.

    Review URL: https://codereview.chromium.org/1710253002

Fixes: #2076
PR-URL: #5577
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
Original commit message:

    Unbreak --gdbjit for embedders.

    Embedders don't use d8.cc.  Move gdbjit initialization to api.cc.

    Review URL: https://codereview.chromium.org/1710253002

Fixes: #2076
PR-URL: #5577
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
MylesBorins pushed a commit that referenced this pull request Apr 8, 2016
Original commit message:

    Unbreak --gdbjit for embedders.

    Embedders don't use d8.cc.  Move gdbjit initialization to api.cc.

    Review URL: https://codereview.chromium.org/1710253002

Fixes: #2076
PR-URL: #5577
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
Notable Changes:

deps:
  - Fix `--gdbjit` for embedders. Backported from v8 upstream.
    (Ben Noordhuis) #5577

etw:
  - Correctly display descriptors for ETW events 9 and 23 on the
    windows platform.
    (João Reis) #5742

querystring:
  - Restore throw when attempting to stringify bad surrogate pair.
    (Brian White) #5858
MylesBorins pushed a commit that referenced this pull request Apr 12, 2016
Notable Changes:

deps:
  - Fix `--gdbjit` for embedders. Backported from v8 upstream.
    (Ben Noordhuis) #5577

etw:
  - Correctly display descriptors for ETW events 9 and 23 on the
    windows platform.
    (João Reis) #5742

querystring:
  - Restore throw when attempting to stringify bad surrogate pair.
    (Brian White) #5858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants