querystring: don't stringify bad surrogate pair #5858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
querystring
|
LGTM |
mscdex
force-pushed
the
querystring-stringify-bad-surrogate
branch
from
1a97620
to
0617099
Compare
|
LGTM, this behavior makes a lot more sense. |
|
LGTM. The CI failure looks unrelated. |
|
LGTM I know this is technically restoring a throw that was there previously, but since this adds the throw back in it's technically a semver-major. How do we want to treat this one? |
|
@jasnell The backwards incompatibility was not intentional so I would see this as a bug fix and thus not |
|
Ok, then on that point this should also make it's way into v4 and should likely be noted in the notable changes on the relevant releases. |
Fixes: nodejs#3702 PR-URL: nodejs#5858 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
mscdex
force-pushed
the
querystring-stringify-bad-surrogate
branch
from
0617099
to
c169ac6
Compare
|
@mscdex this is not landing cleanly, would you be able to backport? |
mscdex
added a commit
to mscdex/io.js
that referenced
this pull request
Apr 8, 2016
Fixes: nodejs#3702 PR-URL: nodejs#5858 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 11, 2016
Notable Changes:
deps:
- Fix `--gdbjit` for embedders. Backported from v8 upstream.
(Ben Noordhuis) #5577
etw:
- Correctly display descriptors for ETW events 9 and 23 on the
windows platform.
(João Reis) #5742
querystring:
- Restore throw when attempting to stringify bad surrogate pair.
(Brian White) #5858
MylesBorins
pushed a commit
that referenced
this pull request
Apr 12, 2016
Notable Changes:
deps:
- Fix `--gdbjit` for embedders. Backported from v8 upstream.
(Ben Noordhuis) #5577
etw:
- Correctly display descriptors for ETW events 9 and 23 on the
windows platform.
(João Reis) #5742
querystring:
- Restore throw when attempting to stringify bad surrogate pair.
(Brian White) #5858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
Affected core subsystem(s)
Description of change
Fixes: #3702