Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: cctest TAP output changes #9682

Closed
wants to merge 6 commits into from
Closed

backport: cctest TAP output changes #9682

wants to merge 6 commits into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Nov 18, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • test
Description of change

This is a backport of:

/cc @bnoordhuis @jbergstroem

CI: https://ci.nodejs.org/job/node-test-pull-request/4897/

bnoordhuis and others added 6 commits November 18, 2016 15:27
@bnoordhuis @mscdex
deps: make gtest output tap
f72f02f 
Teach gtest to produce TAP so we can integrate it better with our CI
tooling.

TAP is printed to stdout but it can also be written to file by passing
the `--gtest_output=tap:filename.tap` switch to cctest.

PR-URL: nodejs#8034
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis @mscdex
build: run cctests as part of test-ci target
938e67a 
Enable the cctests on the CI now that they know how to write TAP output.

PR-URL: nodejs#8034
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex
deps: revert default gtest reporter change
7f81919 
PR-URL: nodejs#8948
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jbergstroem @mscdex
test: output tap13 instead of almost-tap
d2693b1 
Produce a tap13-compatible output which makes it
simpler to parse. Output is still readable by
the jenkins tap plugin.

PR-URL: nodejs#9262
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@jbergstroem @mscdex
gtest: output tap comments as yamlish
a7d90df 
This makes yaml-ish parsers happy.
Note: gtest still seems to output the expected/result slightly
different making the full traceback less informational.

PR-URL: nodejs#9262
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@jbergstroem @mscdex
gitignore: ignore all tap files
0b8be2a 
We now have multiple tap producers; just ignore all
files with the `.tap` extension.

PR-URL: nodejs#9262
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@mscdex mscdex added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. v4.x labels Nov 18, 2016
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v4.x labels Nov 18, 2016
@mscdex mscdex changed the title Backport v4 pr 8034 8948 9262 backport: cctest TAP output changes Nov 18, 2016
@mscdex mscdex mentioned this pull request Nov 18, 2016
Merged
@MylesBorins
Copy link
Contributor

looks like infra problems with vs2013 /cc @nodejs/build

@mscdex
Copy link
Contributor Author

mscdex commented Nov 18, 2016

Looks like infrastructure issue with freebsd11 too (compiler issue -- too old maybe?). I noticed the same issue on another backport.

@mscdex
Copy link
Contributor Author

mscdex commented Nov 18, 2016 •
edited
Loading

CI again for Windows only: https://ci.nodejs.org/job/node-test-commit-windows-fanned/5329/

Looks like VS2013 is building this time...

EDIT: d'oh, looks like VCBT2015 failed now... :-(

@jbergstroem
Copy link
Member

FreeBSD 11: my bad. was supposed to fix it yesterday, will get on it soon.

@MylesBorins
Copy link
Contributor

One more go at CI: https://ci.nodejs.org/job/node-test-pull-request/4932/

@mscdex
Copy link
Contributor Author

mscdex commented Nov 22, 2016

Huh... I'm not sure why this showed up in the freebsd11 log:

Building Node.js 4.x or older isn't supported on FreeBSD 11
/tmp/hudson1047485447156305598.sh: line 8: return: can only `return' from a function or sourced script

(especially the node v4.x comment)

@MylesBorins
Copy link
Contributor

@mscdex thats from our infra. Building v4 is broken on BSD 11 and @jbergstroem was working on something to bypass the job, it doesn't look like it is working quite right

@MylesBorins
Copy link
Contributor

it seems like there are failures on AIX on this run as well... but they appear to be identical to the failures popping up over in #9695

I'm going to see if something landed on v4.x that could be causing these failures... they are not related to this PR

@MylesBorins
Copy link
Contributor

AIX failures are unrelated landing.

@MylesBorins
Copy link
Contributor

landed in 66e26cd...02e6c84

@mscdex mscdex deleted the backport-v4-pr-8034-8948-9262 branch November 22, 2016 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mscdex @MylesBorins @jbergstroem @bnoordhuis @nodejs-github-bot