Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgram: generalized send queue to handle close #9695

Closed
wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

dgram

Description of change

If the udp socket is not ready and we are accumulating
messages to send, it needs to delay closing the socket when
all messages are flushed.

Backport of #7066

cc @thealphanerd

If the udp socket is not ready and we are accumulating
messages to send, it needs to delay closing the socket when
all messages are flushed.

Fixes: nodejs#7061
PR-URL: nodejs#7066
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. v4.x labels Nov 19, 2016
@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 22, 2016
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 22, 2016

handful of failures on AIX https://ci.nodejs.org/job/node-test-commit-aix/2006/nodes=aix61-ppc64/tapTestReport/

/cc @nodejs/platform-aix

edit: the sam AIX failures are showing up in other unrelated PR's

@MylesBorins
Copy link
Contributor

arm failure is infra related... AIX failures unrelated. Landed in 4571c84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants