Convert prism-tomorrow.css to stylus and include it in our main CSS. #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I have based my PRs on this, I think it makes sense to move on with this for the time being. When the Sass PR is merged, the prism CSS file will be restored. |
|
@nodejs/website |
alexandrtovmach
approved these changes
Sep 18, 2019
Aissaoui-Ahmed
suggested changes
Sep 19, 2019
|
|
||
| code[class*='language-'], | ||
| pre[class*='language-'] | ||
| color #ccc |
There was a problem hiding this comment.
It's a 3rd-party file, I'd rather keep it close to the original.
Aissaoui-Ahmed
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2461!
The idea is to combine the Prism CSS with our main CSS and thus run autoprefixer and minifier like our main CSS file.
I know it's a 3rd-party file and we probably shouldn't touch it, but this way we end up with less CSS, which has the same transformations applied as our main CSS file.
Let me know your thoughts. I tried just
@importing the Prism CSS file in our styl file, but then it wasn't being minified. I'll give that another go later, because this solution would be the least intrusive one.