Move inline JS to static/js/main.js. #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about we move all JS (maybe not the IE custom modernizr load) to a file named main.js instead of 2 files? I know we have http/2, but these are small files and this way we keep things simple. |
|
I will go with the one file solution. This way we won't have multiple JS files and we won't need to look into concatenating them on build. I think it's a good compromise given the nature of the project. |
|
Marked it as ready for review. I only left the IE modernizer check in the HTML. Let me know what you guys think. (Preview #2543 (comment)) PS. I hope no one links to download.js from other Node.js sites. If so, we'll need to rethink this. |
|
I moved everything to main.js. Now the HTML files are free from inline JS. |
|
@nodejs/website This could use some reviews. |
alexandrtovmach
approved these changes
Oct 1, 2019
aymen94
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably finish #2465, #2462 and look into #2523 before this.Fixes #2542
Preview: https://elastic-wing-9ce26c.netlify.com/en/