ZMS-172 #733
Open
ZMS-172 #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andris9
requested changes
Sep 16, 2024
andris9
requested changes
Sep 19, 2024
| } | ||
| ); | ||
| } | ||
| } | ||
| callback(...args); |
There was a problem hiding this comment.
There's a potential race condition if we want to use the sha256 hash immediately after the attachment has been uploaded - there's a chance that the findOneAndUpdate call is not finished yet, and thus, the value is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an attachment gets uploaded calculate sha256 hash of it's content and store in the file metadata in the DB.