-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZMS-172 #733
Open
NickOvt
wants to merge
19
commits into
master
Choose a base branch
from
ZMS-172
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ZMS-172 #733
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b3d48ce
Added submission api endpoint to api docs generation
NickOvt c01170f
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt 3f1c3e0
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt 1a0272d
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt b2aaba5
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt 7d4eb9f
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt 3bc4530
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt 8fdc0d3
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt 2607896
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt 10836eb
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt ea9e4e0
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt 4c2f07d
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt c0f0660
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt ceeacc7
Merge branch 'master' of github.com:nodemailer/wildduck
NickOvt 6a9bae9
on attachment upload calculate file content hash
NickOvt 2d8b782
make stream into separate file, refactor
NickOvt e3afdec
create stream during the try to store. otherwise getting stuck
NickOvt 6515b27
refactor file content hash update
NickOvt daa9767
safer file content hash handling
NickOvt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
'use strict'; | ||
|
||
const Transform = require('stream').Transform; | ||
const crypto = require('crypto'); | ||
|
||
class FileHashCalculatorStream extends Transform { | ||
constructor(options) { | ||
super(options); | ||
this.bodyHash = crypto.createHash('sha256'); | ||
this.hash = null; | ||
} | ||
|
||
updateHash(chunk) { | ||
this.bodyHash.update(chunk); | ||
} | ||
|
||
_transform(chunk, encoding, callback) { | ||
if (!chunk || !chunk.length) { | ||
return callback(); | ||
} | ||
|
||
if (typeof chunk === 'string') { | ||
chunk = Buffer.from(chunk, encoding); | ||
} | ||
|
||
this.updateHash(chunk); | ||
this.push(chunk); | ||
|
||
callback(); | ||
} | ||
|
||
_flush(done) { | ||
this.hash = this.bodyHash.digest('base64'); | ||
done(); | ||
} | ||
} | ||
|
||
module.exports = FileHashCalculatorStream; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential race condition if we want to use the sha256 hash immediately after the attachment has been uploaded - there's a chance that the
findOneAndUpdate
call is not finished yet, and thus, the value is not available.