Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling tweaks #157

Merged
merged 1 commit into from
Oct 15, 2013
Merged

Styling tweaks #157

merged 1 commit into from
Oct 15, 2013

Conversation

akre54
Copy link
Contributor

@akre54 akre54 commented Oct 14, 2013

This pull doesn't introduce any logic changes, but it tweaks some internals, notably with this context and === instead of ==, some underscore method tweaks, and keeping the selector as ":el". Mostly trying to keep == from biting with edge cases.

@delambo delambo merged commit e44b1c1 into nytimes:master Oct 15, 2013
@delambo
Copy link
Member

delambo commented Oct 15, 2013

Beautiful. Thank you.

@rjharmon
Copy link

I like the removal of self = this when not needed, as in some of this diff. Unfortunately, the change introduced a this inaccuracy in the call to updateViewBindEl() inside the event-handler, where the event's context has this as, e.g., HTMLInputElement instead of a view instance. Pull req pending.

I only see one other potential case of this. Both lines flagged as notes in the commit itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants