Update for lodash v4. compatibility #308
Conversation
Modifications to support lodash v4. - ‘this’ can’t be passed as the final argument in things like _.each, and must instead be bound explicitly via _.bind. - ‘invoke’ is now ‘invokeMap’, but underscore lacks ‘invokeMap’. To run with both underscore and lodash, convert to an _.each loop. - ‘contains’ is now ‘includes’. As underscore has ‘includes’ as an alias for ‘contains’, convert to ‘includes’.
|
Ha. I swapped these out a couple years back (#157) because I like the 3rd arg style a bit more. I don't really like the rest of the lodash changes either as I think they make the code harder to read, but thanks for going through this and cleaning up places. Finally, I think we're at the point where we can use Function.prototype.bind instead of |
|
|
||
| // Call `_destroy` on a unique list of the binding callbacks. | ||
| _.each(_.uniq(destroyFns), function(fn) { fn.call(this); }, this); | ||
| _.each(_.uniq(destroyFns), _.bind(function(fn) { fn.call(this); }, this)); |
There was a problem hiding this comment.
how about just bind here, since that's what this function is doing anyway?
|
Well, so far as bind vs. _.bind vs self, doesn't much matter to me. However, since you "don't really like the rest of the lodash changes either", that's pretty much a nonstarter, so probably best just to close the PR. |
|
No I mean I don't much like the changes JDD has made. But if this helps people with compatibility happy to merge in. Wanna tweak the minor fixes and then we can |
|
JDD's ways are such a mystery to us all. So I think this nets out to replacing all the _.bind calls with native bind, which seems to affect only IE8 types, which seems like acceptable losses. All straightforward changes but for the 'destroyFns' loop, which I need to get my head around -- suggestions welcome on that one. |
|
Sure, that sounds reasonable. Forget my second point, I got confused :) |
|
Changed to use native bind(). |
Modifications to support lodash v4.
and must instead be bound explicitly via _.bind.
with both underscore and lodash, convert to an _.each loop.
alias for ‘contains’, convert to ‘includes’.