Make output directories of RobotImporter unique #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
michalpelka
reviewed
Jul 10, 2023
Gems/ROS2/Code/Source/RobotImporter/Utils/SourceAssetsStorage.h
Outdated
Show resolved
Hide resolved
michalpelka
reviewed
Jul 10, 2023
michalpelka
reviewed
Jul 10, 2023
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
lemonade-dm
reviewed
Jul 10, 2023
Gems/ROS2/Code/Source/RobotImporter/ROS2RobotImporterEditorSystemComponent.cpp
Outdated
Show resolved
Hide resolved
lemonade-dm
reviewed
Jul 10, 2023
lemonade-dm
reviewed
Jul 10, 2023
lemonade-dm
reviewed
Jul 10, 2023
lemonade-dm
reviewed
Jul 10, 2023
Gems/ROS2/Code/Source/RobotImporter/Utils/SourceAssetsStorage.cpp
Outdated
Show resolved
Hide resolved
lemonade-dm
reviewed
Jul 10, 2023
Gems/ROS2/Code/Source/RobotImporter/Utils/SourceAssetsStorage.cpp
Outdated
Show resolved
Hide resolved
lemonade-dm
reviewed
Jul 10, 2023
Gems/ROS2/Code/Source/RobotImporter/Utils/SourceAssetsStorage.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
adamdbrw
approved these changes
Jul 11, 2023
arturkamieniecki
approved these changes
Jul 12, 2023
michalpelka
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Uuid of parameters passed to XACRO to the name name of RobotImporter's output directory.
This makes the directory unique for each robot imported from the same xacro file.
Addresses #392.