Fixed directory name creation in URDF Importer #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
lemonade-dm
reviewed
Jul 26, 2023
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
lewandowskikacper
force-pushed
the
fix_urdf_import_directory_suffix
branch
from
8dd7ee6
to
8281405
Compare
michalpelka
approved these changes
Jul 27, 2023
adamdbrw
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#394 resolved #392 by introducing
dirSuffix- additional directory path part, that was added in order to make it unique.In #394
dirSuffixis anAZStd::string_viewcreated fromparamsUuid.ToString<AZStd::string_view>(), which is an error, as the string is a temporary value.This PR changes it to be a
AZStd::stringinstead, so that it's value lives for the duration of call toCopyAssetForURDFAndCreateAssetMap.