-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement contact sensor component. #418
Implement contact sensor component. #418
Conversation
c166eb2
to
de0f426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I did not run it yet. Please adjust PR to review.
Gems/ROS2/Code/Source/ContactSensor/ROS2ContactSensorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/ContactSensor/ROS2ContactSensorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/ContactSensor/ROS2ContactSensorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/ContactSensor/ROS2ContactSensorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/ContactSensor/ROS2ContactSensorComponent.cpp
Outdated
Show resolved
Hide resolved
54866e7
to
ba3170e
Compare
Gems/ROS2/Code/Source/ContactSensor/ROS2ContactSensorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/ContactSensor/ROS2ContactSensorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/ContactSensor/ROS2ContactSensorComponent.h
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/ContactSensor/ROS2ContactSensorComponent.h
Outdated
Show resolved
Hide resolved
7fe56a7
to
3cf918e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not want to merge it until commented case would be resolved.
@michalpelka |
Signed-off-by: Anna Faferek <anna.faferek@robotec.ai>
Signed-off-by: Anna Faferek <anna.faferek@robotec.ai>
Signed-off-by: Anna Faferek <anna.faferek@robotec.ai>
… Modify the component to only publish messages when a contact exists Signed-off-by: Anna Faferek <anna.faferek@robotec.ai>
Signed-off-by: Anna Faferek <anna.faferek@robotec.ai>
00c02d7
to
352d130
Compare
Fixes: #405