Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in TempInputScalar that causes AddressSanitizer to report a "stack-buffer-overflow" #3231

Merged
merged 1 commit into from
May 15, 2020
Merged

Fix typo in TempInputScalar that causes AddressSanitizer to report a "stack-buffer-overflow" #3231

merged 1 commit into from
May 15, 2020

Conversation

MrMetric
Copy link
Contributor

I pulled the latest code today, and my DragScalar and SliderScalar scalar calls with double values suddenly cause a crash when I type in a value. I used git bisect to find that the commit with the error is 0679e05.

@ocornut ocornut added the bug label May 15, 2020
@ocornut ocornut merged commit 39c978f into ocornut:master May 15, 2020
@ocornut
Copy link
Owner

ocornut commented May 15, 2020

Thank you @MrMetric !
Quite an embarassing bug.
It shows that our regression testing framework was not exercising nor testing this properly, we will add extra tests now.

@MrMetric MrMetric deleted the fix-TempInputScalar branch May 16, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrMetric @ocornut