Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device major minor numbers #1190

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cesarpastorini
Copy link

Hello, this PR builds on top of @SteveLauC work adding a commit to settle the conflicting return types of major() and minor() functions outlined at the end of this comment.

SteveLauC and others added 3 commits May 2, 2023 22:08
This is meant as the final step in fixing ogham#1126.

The different build targets of Rust libc's `major()` and `minor()`
functions have conflicting return types like `c_uint`, `c_int` and
`i32`, so an `i64` should be able to represent all of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants