Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix device major minor numbers #1190

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix device major minor numbers #1190

wants to merge 3 commits into from

Commits on May 3, 2023

  1. feat: device number

    @SteveLauC @cesarpastorini
    SteveLauC authored and cesarpastorini committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a2cf45d View commit details
    Browse the repository at this point in the history

  2. remove the type cast

    @SteveLauC @cesarpastorini
    SteveLauC authored and cesarpastorini committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b854e7d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Use i64 to accomodate for device files' major and minor numbers 

    This is meant as the final step in fixing ogham#1126.

The different build targets of Rust libc's `major()` and `minor()`
functions have conflicting return types like `c_uint`, `c_int` and
`i32`, so an `i64` should be able to represent all of them.
    @cesarpastorini
    cesarpastorini committed May 4, 2023
    Configuration menu
    Copy the full SHA
    33fae8b View commit details
    Browse the repository at this point in the history