Enable account linking / AuthAccount capabilities on all networks except Mainnet #3910
Conversation
turbolent
requested review from
ramtinms,
janezpodhostnik,
pattyshack and
m4ksio
as code owners
| newCustomRuntime func() runtime.Runtime, | ||
| ) ReusableCadenceRuntimePool { | ||
| var pool chan *ReusableCadenceRuntime | ||
| if poolSize > 0 { | ||
| pool = make(chan *ReusableCadenceRuntime, poolSize) | ||
| } | ||
|
|
||
| // Enable account linking on all networks except Mainnet | ||
| config.AccountLinkingEnabled = chainID != flow.Mainnet |
There was a problem hiding this comment.
minor: I would prefer this set being higher up so chainID doesn't need to get sent so deep just for this.
But since this is just temporary for 0.29 its ok.
There was a problem hiding this comment.
+1 if you're porting this to head
There was a problem hiding this comment.
I wasn't sure how to enforce this setting consistently everywhere. It would be great if someone from the execution team with more knowledge about flow-go/FVM could advise / perform the refactor.
This is not just temporary for 0.29, but will also get ported to master.
| newCustomRuntime func() runtime.Runtime, | ||
| ) ReusableCadenceRuntimePool { | ||
| var pool chan *ReusableCadenceRuntime | ||
| if poolSize > 0 { | ||
| pool = make(chan *ReusableCadenceRuntime, poolSize) | ||
| } | ||
|
|
||
| // Enable account linking on all networks except Mainnet | ||
| config.AccountLinkingEnabled = chainID != flow.Mainnet |
There was a problem hiding this comment.
+1 if you're porting this to head
Codecov Report
@@ Coverage Diff @@
## v0.29 #3910 +/- ##
==========================================
- Coverage 53.47% 51.84% -1.64%
==========================================
Files 812 178 -634
Lines 76105 16672 -59433
==========================================
- Hits 40695 8643 -32052
+ Misses 32113 7504 -24609
+ Partials 3297 525 -2772
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
bors merge |
|
bors merge |
|
Build failed: |
|
bors merge |
|
Canceled. |
|
bors merge |
4017: Update to Cadence v0.36.0 r=turbolent a=dsainati1 ## Description Update to: - [onflow/flow-go-sdk v0.35.0](https://github.com/onflow/flow-go-sdk/releases/tag/v0.35.0) - [onflow/cadence v0.36.0](https://github.com/onflow/cadence/releases/tag/v0.36.0) Port from v0.29: - #3910 - #3920 - #3969 - #3997 Co-authored-by: Daniel Sainati <sainatidaniel@gmail.com> Co-authored-by: Bastian Müller <bastian@axiomzen.co> Co-authored-by: Supun Setunga <supun.setunga@gmail.com> Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>
No description provided.