Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v0.31.5-account-link-pragma #3969

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 28, 2023

Cadence v0.31.5-account-link-pragma is v0.31.5 + account linking pragma (onflow/cadence#2359 / onflow/cadence#2355)

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an FVM test to ensure the pragma + flag works as intended

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. can you add a note to the description about what this adds/enables?

@turbolent
Copy link
Member Author

@peterargue Linked the original PR (which was linked in the port PR), i.e. see the description in onflow/cadence#2355

@turbolent
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request Feb 28, 2023
3969: Update to Cadence v0.31.5-account-link-pragma r=turbolent a=turbolent

Cadence v0.31.5-account-link-pragma is v0.31.5 + account linking pragma (onflow/cadence#2359 / onflow/cadence#2355)

Co-authored-by: Bastian Müller <bastian@axiomzen.co>
@bors
Copy link
Contributor

bors bot commented Feb 28, 2023

Build failed:

@turbolent
Copy link
Member Author

@j1010001 @SupunS @dsainati1 I enabled account linking for all chains, while requiring the use of the new pragma in 4f2e55e, please have a look

@turbolent turbolent requested a review from dsainati1 March 1, 2023 00:00
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@turbolent
Copy link
Member Author

bors merge

@bors bors bot merged commit d27a156 into v0.29.16-height-coordinated-upgrade Mar 1, 2023
@bors bors bot deleted the bastian/cadence-v0.31.5-account-link-pragma branch March 1, 2023 22:30
bors bot added a commit that referenced this pull request Mar 10, 2023
4017: Update to Cadence v0.36.0 r=turbolent a=dsainati1



## Description

Update to:
- [onflow/flow-go-sdk v0.35.0](https://github.com/onflow/flow-go-sdk/releases/tag/v0.35.0)
- [onflow/cadence v0.36.0](https://github.com/onflow/cadence/releases/tag/v0.36.0)

Port from v0.29:
- #3910
- #3920
- #3969
- #3997

Co-authored-by: Daniel Sainati <sainatidaniel@gmail.com>
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants