-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EVM] Fix the setup process #5069
Conversation
fvm/transactionInvoker.go
Outdated
@@ -12,7 +14,6 @@ import ( | |||
|
|||
"github.com/onflow/flow-go/fvm/environment" | |||
"github.com/onflow/flow-go/fvm/errors" | |||
"github.com/onflow/flow-go/fvm/evm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't need to move.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah damn goland
Thanks for finding this! |
Thank you for the fix. I'm not familiar with the FVM internals, what was broken? Can you please add a test that fails without the fix? That prevents future regressions |
I'm just doing that yeah. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5069 +/- ##
==========================================
+ Coverage 56.23% 57.50% +1.27%
==========================================
Files 977 786 -191
Lines 91105 74606 -16499
==========================================
- Hits 51232 42904 -8328
+ Misses 36066 28478 -7588
+ Partials 3807 3224 -583
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closes: #5068
This PR fixes an issue with EVM setup. It moves the setup in the preprocess of the transaction invoker, since the Cadence env needs to have
EVMInternal
values set during the preprocess as it loads the transaction program and the checker fails otherwise.