Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EVM test #5215

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Update EVM test #5215

merged 1 commit into from
Jan 18, 2024

Conversation

janezpodhostnik
Copy link
Contributor

The EVM test had some workarounds that are no longer needed since #5106.

The EVM test had some workarounds that are no longer needed.
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1fdaa8) 56.55% compared to head (120ef8f) 56.33%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5215      +/-   ##
==========================================
- Coverage   56.55%   56.33%   -0.23%     
==========================================
  Files         988      994       +6     
  Lines       94422    94848     +426     
==========================================
+ Hits        53403    53432      +29     
- Misses      37054    37441     +387     
- Partials     3965     3975      +10     
Flag Coverage Δ
unittests 56.33% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

@ramtinms
Copy link
Member

ramtinms commented Jan 9, 2024

hmm, can you point me to the code changes that solved this problem?

@sideninja
Copy link
Member

@ramtinms this was related to the fact the EVM setup was not done in the correct place: #5069

@janezpodhostnik janezpodhostnik added this pull request to the merge queue Jan 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 11, 2024
@janezpodhostnik janezpodhostnik added this pull request to the merge queue Jan 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 12, 2024
@janezpodhostnik janezpodhostnik added this pull request to the merge queue Jan 18, 2024
Merged via the queue into master with commit 3c27e97 Jan 18, 2024
51 checks passed
@janezpodhostnik janezpodhostnik deleted the janez/update-evm-test branch January 18, 2024 15:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants