Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BB-3686] Create separate requirements file for Ansible 2.8.17 #202

Merged

Conversation

0x29a
Copy link
Member

@0x29a 0x29a commented Feb 17, 2021

Including separate requirements file, similar to https://github.com/open-craft/ansible-playbooks/blob/master/requirements.txt, but with Ansible 2.8.17, which is required to run playbooks against Ubuntu 20.04.

JIRA tickets:

Dependencies:

Testing instructions:

Look open-craft/opencraft#713.

Reviewers

@0x29a 0x29a requested a review from shimulch February 17, 2021 12:03
@0x29a 0x29a changed the title [WIP] [BB-3686] Create separate requirements file for Ansible 2.8.17 [BB-3686] Create separate requirements file for Ansible 2.8.17 Feb 17, 2021
Copy link
Contributor

@shimulch shimulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • I tested this on the deployed app server and instance on stage.
  • I read through the code
  • [N/A] I checked for accessibility issues
  • [N/A] Includes documentation
  • [N/A] I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@0x29a 0x29a merged commit 2908052 into master Feb 23, 2021
@0x29a 0x29a deleted the 0x29a/bb3686/separe_requirements_file_for_ansible2.8.17 branch February 23, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants