Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[BB-3686] Change ANSIBLE_APPSERVER_REQUIREMENTS_PATH to requirements_ansible_2.8.17.txt #713

Merged

Conversation

0x29a
Copy link
Member

@0x29a 0x29a commented Feb 17, 2021

Changes ANSIBLE_APPSERVER_REQUIREMENTS_PATH to requirements_ansible_2.8.17.txt and adds migration to update default value in the database.

Currently, when we want to run koa/master Open edX app server, we have to use a separate branch from ansible-playbooks repo. So, we always need to rebase this branch from master. This PR solves this issue and enables Ansible 2.8.17 for appserver.yml playbook by default.

With fixes that are already merged in master, Ansible 2.8.17 has proven to be stable for Ubuntu 16.04 and 20.04, so this change is safe.

JIRA tickets:

Dependencies:

Testing instructions:

  1. Attach to the stage Ocim screen, and switch window to bash.
  2. Checkout branch to 0x29a/bb3686/change_default_appserver_requirements_file.
  3. Switch window to ipython and restart the shell.
  4. Ensure that settings.ANSIBLE_APPSERVER_REQUIREMENTS_PATH equals to requirements_ansible_2.8.17.txt.
  5. Switch window to bash and run make migrate.
  6. After migration is finished, switch back to ipython window and create test instance: production_instance_factory(sub_domain='bb3686').
  7. Go to https://stage.manage.opencraft.com/admin/, open settings for the instance with bb3686 sub-domain.
  8. You should see that Ansible appserver requirements path is equal to requirements_ansible_2.8.17.txt.
  9. Change Ansible appserver version to 0x29a/bb3686/separe_requirements_file_for_ansible2.8.17.
  10. Leave Openstack server base image as is. Our goal is to check that everything works for current default release, juniper.3.
  11. Create app server for this instance and ensure that it provisioned fine.

Reviewers

@0x29a 0x29a requested a review from shimulch February 17, 2021 12:24
@0x29a 0x29a changed the title [WIP] [BB-3686] Change ANSIBLE_APPSERVER_REQUIREMENTS_PATH to requirements_ansible_2.8.17.txt [BB-3686] Change ANSIBLE_APPSERVER_REQUIREMENTS_PATH to requirements_ansible_2.8.17.txt Feb 17, 2021
@0x29a
Copy link
Member Author

0x29a commented Feb 17, 2021

Test failure is expected, since there is no straightforward way of changing appserver's setting. Test will pass after merging related PR against ansible-playbooks.

Copy link
Contributor

@shimulch shimulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • I tested this on the deployed app server and instance in the stage.
  • I read through the code
  • [N/A] I checked for accessibility issues
  • [N/A] Includes documentation
  • [N/A] I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@0x29a 0x29a force-pushed the 0x29a/bb3686/change_default_appserver_requirements_file branch from 2ae1fa7 to b5c4440 Compare February 23, 2021 16:33
@0x29a 0x29a force-pushed the 0x29a/bb3686/change_default_appserver_requirements_file branch from b5c4440 to b486234 Compare February 25, 2021 09:06
@0x29a 0x29a merged commit 3002e8d into master Feb 25, 2021
@0x29a 0x29a deleted the 0x29a/bb3686/change_default_appserver_requirements_file branch February 25, 2021 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants