-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dkx/support diopi #2368
base: master
Are you sure you want to change the base?
Dkx/support diopi #2368
Conversation
依赖的PR; https://github.com/ParrotsDL/DIOPI/pull/18/commits/ca1eb977e1be9a0fb25933aa601c68f6d6987802 diopi仓 MMCV的nms算子接口需要增加offset参数 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
@@ -0,0 +1,3 @@ | |||
[submodule "DIOPI"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里暂时还没有开源,需要讨论怎么开源
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已开源。
|
||
extern "C" { | ||
|
||
diopiError_t diopiNms(diopiContextHandle_t ctx, diopiTensorHandle_t* out, const diopiTensorHandle_t dets, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个API定义正好在diopi仓库已经定义过,如果不在的话,需要考虑补充进去
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
接口已经定义,待合入:DeepLink-org/DIOPI#13
mmcv/ops/csrc/parrots/cudabind.cpp
Outdated
REGISTER_DEVICE_IMPL(iou3d_nms3d_forward_impl, CUDA, iou3d_nms3d_forward_cuda); | ||
REGISTER_DEVICE_IMPL(iou3d_nms3d_normal_forward_impl, CUDA, | ||
iou3d_nms3d_normal_forward_cuda); | ||
// void IoU3DBoxesOverlapBevForwardCUDAKernelLauncher(const int num_a, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果是需要删除的代码建议直接删除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已删除
setup.py
Outdated
@@ -208,9 +208,17 @@ def get_extensions(): | |||
# define_macros = [('MMCV_USE_PARROTS', None)] | |||
define_macros = [] | |||
include_dirs = [] | |||
op_files = glob.glob('./mmcv/ops/csrc/pytorch/cuda/*.cu') +\ | |||
# op_files = glob.glob('./mmcv/ops/csrc/pytorch/cuda/*.cu') +\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果是需要删除的代码建议直接删除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已删除
…into dkx/support_diopi
will replaced by : |
support diopi for mmcv extension ops