add FusedBiasLeakyRelu npu adapter #2474

jayggh · 2022-12-07T06:23:26Z

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
CLA has been signed and all committers have signed the CLA in this PR.

[Feature] Support engine with NPU backend.

fix autocast bugs on npu (open-mmlab#2273)

add npu extension and focal loss adapter

* fix autocast bugs on npu * using scatter_kwargs in mmcv.device.scatter_gather

* add npu test case

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

… npu-dev

Npu-dev: FocalLoss Adapter BugFix

grimoire

LGTM

CLAassistant · 2022-12-08T12:34:39Z

All committers have signed the CLA.

tests/test_ops/test_fused_bias_leakyrelu.py

* init npu * add npu extension and focal loss adapter * clean code * clean code * clean code * clean code * fix autocast bugs on npu (open-mmlab#2273) fix autocast bugs on npu (open-mmlab#2273) * code format * code format * code format * bug fix * pytorch_npu_helper.hpp clean code * Npu dev (open-mmlab#2306) * fix autocast bugs on npu * using scatter_kwargs in mmcv.device.scatter_gather * raise ImportError when compile with npu * add npu test case (open-mmlab#2307) * add npu test case * Update focal_loss.py * add comment * clean lint * update dtype assert * update DDP forward and comment * fix bug Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> * sigmoidfocalloss npu adapter bug fix * BugFix: modify softmaxFocalLoss adapter * BugFix: remove equal sign in the code * add npu install information in README * add modulatedDeformConv npu adapter * init npu * add npu extension and focal loss adapter * clean code * clean code * clean code * add modulatedDeformConv npu adapter * merge master branch 20221103 * Add masked_ Conv2d operator in NPU * add nms_npu * fix bug * fix code check * fix code check * fix code check * Masked_conv2d NPU * Masked_conv2d NPU * Masked_conv2d NPU * remove npu-install-info in README.md * annotate the clang-format in pre-commit-config-zh-ch.yaml * Clean code: fix the clean code problem in masked_conv2d and modulated_deform_conv * Create fused_bias_leakyrelu_npu.cpp Add NPU adapter for fused_bias_leaky_relu operator * Update fused_bias_leakyrelu_npu.cpp * Update fused_bias_leakyrelu_npu.cpp * Update ops.md * Update ops.md * Update fused_bias_leakyrelu_npu.cpp * Update fused_bias_leakyrelu_npu.cpp * Update test_fused_bias_leakyrelu.py * Update fused_bias_leakyrelu.py * Update test_fused_bias_leakyrelu.py * Update fused_bias_leakyrelu.py * Update test_fused_bias_leakyrelu.py * Update ops.md * amend for CI * bugfix * amend ops.md * Update test_fused_bias_leakyrelu.py * clean code * bugfix * clean code * Update fused_bias_leakyrelu_npu.cpp * Update fused_bias_leakyrelu_npu.cpp Co-authored-by: wangjiangben <wangjiangben_hw@126.com> Co-authored-by: ckirchhoff <515629648@qq.com> Co-authored-by: wangjiangben-hw <111729245+wangjiangben-hw@users.noreply.github.com> Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> Co-authored-by: zcc-zjut <zcczxy2019@163.com> Co-authored-by: wangxiaoxin_sherie <wangxiaoxin7@huawei.com> Co-authored-by: momo609 <963372609@qq.com>

OpenMMLab-Assistant001 · 2023-04-04T10:57:23Z

Hi @jayggh ！First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution！❤

wangjiangben-hw and others added 30 commits September 14, 2022 12:02

init npu

093f462

Merge pull request open-mmlab#2261 from wangjiangben-hw/npu-dev

ba9c36b

[Feature] Support engine with NPU backend.

add npu extension and focal loss adapter

716b3b3

clean code

6e53b3f

clean code

08f0a16

clean code

da659cb

clean code

448476e

fix autocast bugs on npu (open-mmlab#2273)

afbd351

fix autocast bugs on npu (open-mmlab#2273)

code format

26f35e0

code format

58618ac

code format

d75dcb1

bug fix

7af2a6f

pytorch_npu_helper.hpp clean code

268ff0e

Merge pull request open-mmlab#2269 from ckirchhoff2021/npu-dev

9b0133c

add npu extension and focal loss adapter

Npu dev (open-mmlab#2306)

a043541

* fix autocast bugs on npu * using scatter_kwargs in mmcv.device.scatter_gather

raise ImportError when compile with npu

90fc3dc

add npu test case (open-mmlab#2307)

6ffdb57

* add npu test case

Update focal_loss.py

3f11861

add comment

c81daa3

clean lint

1cee865

update dtype assert

5841f92

update DDP forward and comment

4ce938c

fix bug

ea1d8f8

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

sigmoidfocalloss npu adapter bug fix

8c0945c

BugFix: modify softmaxFocalLoss adapter

183e4af

BugFix: remove equal sign in the code

9d1376e

add npu install information in README

33dbcde

Merge branch 'npu-dev' of https://github.com/ckirchhoff2021/mmcv into…

cf49223

… npu-dev

Merge pull request open-mmlab#2323 from ckirchhoff2021/npu-dev

21b94c1

Npu-dev: FocalLoss Adapter BugFix

add modulatedDeformConv npu adapter

09dd081

grimoire approved these changes Dec 8, 2022

View reviewed changes

jayggh added 3 commits December 8, 2022 10:26

Update fused_bias_leakyrelu.py

27a3060

Update test_fused_bias_leakyrelu.py

0ec0363

Update ops.md

0869a60

amend for CI

5477510

jayggh force-pushed the npu-dev branch from bd10d12 to 5477510 Compare December 8, 2022 12:50

ckirchhoff2021 reviewed Dec 8, 2022

View reviewed changes

tests/test_ops/test_fused_bias_leakyrelu.py Outdated Show resolved Hide resolved

bugfix

15ac0eb

jayggh force-pushed the npu-dev branch from ce4d005 to 15ac0eb Compare December 8, 2022 13:13

amend ops.md

780e3a1

jayggh force-pushed the npu-dev branch from 0c933b2 to 780e3a1 Compare December 9, 2022 01:52

zhouzaida reviewed Dec 11, 2022

View reviewed changes

tests/test_ops/test_fused_bias_leakyrelu.py Outdated Show resolved Hide resolved

zhouzaida reviewed Dec 11, 2022

View reviewed changes

tests/test_ops/test_fused_bias_leakyrelu.py Outdated Show resolved Hide resolved

zhouzaida reviewed Dec 11, 2022

View reviewed changes

tests/test_ops/test_fused_bias_leakyrelu.py Outdated Show resolved Hide resolved

jayggh and others added 2 commits December 12, 2022 08:47

Update test_fused_bias_leakyrelu.py

7bb7049

clean code

f60c916

jayggh force-pushed the npu-dev branch from eb4a194 to f60c916 Compare December 12, 2022 03:47

Merge branch 'master' of https://github.com/open-mmlab/mmcv into npu-dev

5b645dd

jayggh changed the title ~~add FusedBiasLEakyRelu npu adapter~~ add FusedBiasLeakyRelu npu adapter Dec 12, 2022

zhouzaida reviewed Dec 12, 2022

View reviewed changes

tests/test_ops/test_fused_bias_leakyrelu.py Outdated Show resolved Hide resolved

bugfix

37b0d85

zhouzaida approved these changes Dec 12, 2022

View reviewed changes

jayggh and others added 3 commits December 12, 2022 15:38

clean code

5775477

Update fused_bias_leakyrelu_npu.cpp

2b33fa1

Update fused_bias_leakyrelu_npu.cpp

15a3c76

zhouzaida merged commit 4c51afc into open-mmlab:master Dec 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add FusedBiasLeakyRelu npu adapter #2474

add FusedBiasLeakyRelu npu adapter #2474

jayggh commented Dec 7, 2022

grimoire left a comment

CLAassistant commented Dec 8, 2022 •

edited

Loading

OpenMMLab-Assistant001 commented Apr 4, 2023

add FusedBiasLeakyRelu npu adapter #2474

add FusedBiasLeakyRelu npu adapter #2474

Conversation

jayggh commented Dec 7, 2022

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

grimoire left a comment

Choose a reason for hiding this comment

CLAassistant commented Dec 8, 2022 • edited Loading

OpenMMLab-Assistant001 commented Apr 4, 2023

CLAassistant commented Dec 8, 2022 •

edited

Loading