Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Update digit_version function #865

Closed
wants to merge 3 commits into from

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Aug 11, 2021

Update digit_version function according to open-mmlab/mmcv#1185 and open-mmlab/mmcv#1235

See also open-mmlab/mmpretrain#402

@ly015 ly015 added the status/WIP work in progress label Aug 11, 2021
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #865 (285e6bd) into master (775455d) will decrease coverage by 0.14%.
The diff coverage is 88.88%.

❗ Current head 285e6bd differs from pull request most recent head b68987f. Consider uploading reports for the commit b68987f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
- Coverage   83.59%   83.44%   -0.15%     
==========================================
  Files         176      176              
  Lines       14145    14032     -113     
  Branches     2364     2369       +5     
==========================================
- Hits        11824    11709     -115     
+ Misses       1713     1712       -1     
- Partials      608      611       +3     
Flag Coverage Δ
unittests 83.38% <88.88%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/__init__.py 90.32% <88.88%> (-9.68%) ⬇️
mmpose/datasets/dataset_wrappers.py 50.00% <0.00%> (-4.55%) ⬇️
mmpose/models/detectors/base.py 53.65% <0.00%> (-4.12%) ⬇️
mmpose/core/fp16/hooks.py 25.00% <0.00%> (-2.28%) ⬇️
mmpose/core/camera/camera_base.py 78.57% <0.00%> (-1.43%) ⬇️
mmpose/datasets/datasets/face/face_base_dataset.py 76.47% <0.00%> (-1.31%) ⬇️
mmpose/core/utils/regularizations.py 80.00% <0.00%> (-1.25%) ⬇️
mmpose/models/detectors/pose_lifter.py 68.26% <0.00%> (-1.11%) ⬇️
mmpose/datasets/pipelines/shared_transform.py 86.91% <0.00%> (-1.09%) ⬇️
mmpose/datasets/pipelines/loading.py 85.71% <0.00%> (-0.96%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775455d...b68987f. Read the comment docs.

mmcv_maximum_version = '1.5.0'


def digit_version(version_str: str, length: int = 4):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing is good enough, and do not need to copy the implementation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean importing from mmcv? I think the point of this PR is to avoid import this function from mmcv. Because digit_version from mmcv depends on mmcv version itself, like a circular dependency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually my thinking its the reverse. We will use the implementation of digit_version in mmcv, so that we will get automatic bug fixes.

@ly015 ly015 removed the status/WIP work in progress label Aug 23, 2021
@jin-s13 jin-s13 changed the title Update digit_version function [Enhancement] Update digit_version function Sep 15, 2021
@ly015 ly015 requested a review from jin-s13 September 28, 2021 06:56
@ly015 ly015 closed this Oct 8, 2021
@ly015 ly015 deleted the digit_version branch October 8, 2021 04:28
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants