[Fix] Do not depend on setuptools>=52 #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzaida
reviewed
Aug 2, 2021
kennymckormick
changed the title
kennymckormick
changed the title
|
See concerns here #1185 (comment) |
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
=======================================
Coverage 68.28% 68.28%
=======================================
Files 160 160
Lines 10603 10603
Branches 1937 1938 +1
=======================================
Hits 7240 7240
Misses 2979 2979
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@zhouzaida CI passed |
zhouzaida
reviewed
Aug 7, 2021
18 tasks
ZwwWayne
approved these changes
Aug 10, 2021
ZwwWayne
reviewed
Aug 10, 2021
| @@ -32,6 +30,6 @@ def parse_version_info(version_str: str, length: int = 4) -> tuple: | |||
| return tuple(release) | |||
|
|
|||
|
|
|||
| version_info = parse_version_info(__version__) | |||
| version_info = tuple(int(x) for x in __version__.split('.')[:3]) | |||
There was a problem hiding this comment.
Why do not use parse_version_info here though you wrote it?
There was a problem hiding this comment.
When you execute this line during setup, "packaging" may not exist.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.