Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update digit_version #778

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Conversation

Junjun2016
Copy link
Collaborator

@Junjun2016 Junjun2016 commented Aug 11, 2021

Motivation

The previous digit_version has some problems, refers to open-mmlab/mmcv#1185 and open-mmlab/mmcv#1235

Modification

Copy the digit_version from mmcv and use it to parse version.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Junjun2016
Copy link
Collaborator Author

@zhouzaida

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #778 (e7937c6) into master (58f5dbc) will increase coverage by 0.06%.
The diff coverage is 88.00%.

❗ Current head e7937c6 differs from pull request most recent head 82f79a8. Consider uploading reports for the commit 82f79a8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   85.37%   85.44%   +0.06%     
==========================================
  Files         107      107              
  Lines        5847     5859      +12     
  Branches      960      962       +2     
==========================================
+ Hits         4992     5006      +14     
+ Misses        673      670       -3     
- Partials      182      183       +1     
Flag Coverage Δ
unittests 85.42% <84.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/__init__.py 90.32% <86.95%> (+16.63%) ⬆️
mmseg/datasets/builder.py 89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f5dbc...82f79a8. Read the comment docs.

mmseg/datasets/builder.py Outdated Show resolved Hide resolved
@xvjiarui xvjiarui merged commit bfc3cdb into open-mmlab:master Aug 12, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* update digit_version

* add unittest

* fix import
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* add vipnas link

* use papername instead of keyline in keyword matching

* use unified paper title format

* remove print
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
* add cn pr no

* add comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants