Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] first pass at cleaning up license #21384

Merged
merged 2 commits into from
May 2, 2023
Merged

[chore] first pass at cleaning up license #21384

merged 2 commits into from
May 2, 2023

Conversation

codeboten
Copy link
Contributor

Linked to #21288

[chore] first pass at cleaning up license
8bd354e 
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested a review from a team May 1, 2023 23:02
@dmitryax
Copy link
Member

dmitryax commented May 1, 2023 •
edited
Loading

Same comment as open-telemetry/opentelemetry-collector#7589 (comment)

@atoulme
Copy link
Contributor

atoulme commented May 2, 2023

We can just clean up the files in this PR and discuss the tooling in a separate PR.

add license where missing
75f6e10 
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten
Copy link
Contributor Author

After discussing this w/ @dmitryax, we agreed that it makes sense to check the license using the same check as the opentelemetry-go-build-tools repo, as addlicense doesn't check the formatting of the license.

I've updated checklicense to use awk instead.

@codeboten codeboten requested a review from a team May 2, 2023 15:55
dmitryax
dmitryax approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @codeboten thank you!

@codeboten codeboten merged commit feef55b into open-telemetry:main May 2, 2023
@codeboten codeboten deleted the codeboten/license-check branch May 2, 2023 22:56
@github-actions github-actions bot added this to the next release milestone May 2, 2023
@codeboten codeboten mentioned this pull request May 3, 2023
Closed
@mx-psi mx-psi mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@dmitryax dmitryax dmitryax approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

Assignees

@atoulme atoulme

Labels
exporter/alibabacloudlogservice Alibaba components exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awsemf awsemf exporter exporter/awskinesis exporter/awss3 exporter/awsxray exporter/clickhouse exporter/datadog Datadog components exporter/logicmonitor receiver/awscloudwatch receiver/filestats receiver/haproxy receiver/hostmetrics receiver/k8sobjects receiver/snmp
Projects
None yet
Milestone
v0.77.0
Development

Successfully merging this pull request may close these issues.
3 participants
@codeboten @dmitryax @atoulme