[chore] add license-check #7589
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7589 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 296 296
Lines 14472 14472
=======================================
Hits 13203 13203
Misses 1004 1004
Partials 265 265
☔ View full report in Codecov by Sentry. |
|
We already have I think the problem with the existing |
We likely don't need another one. I just used the check license from the opentelemetry-go-build-tools repo. I don't care which way we end up going, but i do like the simplicity of the check w/ awk |
|
After testing this out, i don't think addlicense will tell us if a license is different than what's expected. I ran it on the repo as is, and although it added licenses to any missing files, it left these in place (note the 2 spaces after Copyright): It's possible I misused |
|
After discussing this w/ @dmitryax, we agreed that it makes sense to check the license using the same check as the opentelemetry-go-build-tools repo, as addlicense doesn't check the formatting of the license. I've updated |
There was a problem hiding this comment.
LGTM on the fixes, I will let you folks @dmitryax and @codeboten to decide which tool to use.
| @@ -1,4 +1,18 @@ | |||
| #!/bin/bash -ex | |||
| # | |||
| # Copyright The OpenTelemetry Authors | |||
There was a problem hiding this comment.
Should this be before the first line?
There was a problem hiding this comment.
I push the copyright notice after as shellcheck complains
First pass at cleaning up the license in files. Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/license-check
branch
from
d8da8a6
to
1ae03e6
Compare
First pass at cleaning up the license in files.