[cmd/githubgen] add distribution reports #29697
Conversation
atoulme
force-pushed
the
add_distribution_owners
branch
from
8a9012d
to
fcfe158
Compare
atoulme
force-pushed
the
add_distribution_owners
branch
4 times, most recently
from
f8543d6
to
bae846b
Compare
| maintainers: [] | ||
| components: | ||
| receiver: | ||
| - gitprovider |
There was a problem hiding this comment.
It looks odd to me that a distribution has a single component
There was a problem hiding this comment.
heh well it might be so much value that's all they need.
There was a problem hiding this comment.
@adrielp Does liatrio's distro only have one component?
There was a problem hiding this comment.
Nope @mx-psi, you're spot on. I need to come back and updated this. This is what we include taken from this manifest.yaml (i've updated the distro faster than I could open pr's for sure)
Extensions:
- zpages
- ballast
- basicauth
- healthcheck
- pprof
- bearertokenauth
- sigv4auth
exporters:
- logging
- otlphttp
- awsxray
- awscloudwatchlogs
- influxdb
- prometheus
- zipkiin
- prometheusremotewrite
processors:
- batchprocessor
- memorylimiter
- resourcedetection
- resource
- k8sattributes
- transform
- filter
receivers:
- otlp
- gitprovider
- prometheus
- kubeletestats
- k8scluster
- jaeger
- zipkin
connectors:
- spanmetrics
Do you want me to make a suggestion to this file to add them? If so, totally happy to do it ASAP such that I don't block any work.
There was a problem hiding this comment.
you need to add this to the metadata.yaml of every component you include, and then this tool will pick up the changes and build the report.
This is not blocking this PR.
There was a problem hiding this comment.
@atoulme - want me to go ahead and do that now through a separate PR such that it can be picked up through this one?
There was a problem hiding this comment.
Please open a PR, and we'll see which one lands first.
atoulme
force-pushed
the
add_distribution_owners
branch
from
3d00a28
to
074288e
Compare
|
Thanks for splitting out the PRs, should be good now if you rebase :) |
atoulme
force-pushed
the
add_distribution_owners
branch
from
5366409
to
01620ad
Compare
| - name: grafana | ||
| url: https://github.com/grafana/agent | ||
| - name: observiq | ||
| url: https://github.com/observIQ/observiq-otel-collector |
There was a problem hiding this comment.
The observIQ distribution is now at https://github.com/observIQ/bindplane-agent, the original link will redirect.
There was a problem hiding this comment.
go ahead and open a PR to fix, and feel free to add yourself as maintainer so you can keep on top of this type of changes moving forward, thanks!
| @@ -0,0 +1,117 @@ | |||
| name: observiq | |||
| url: https://github.com/observIQ/observiq-otel-collector | |||
There was a problem hiding this comment.
Same as previous comment: https://github.com/observIQ/bindplane-agent
Description:
Adds a set of distribution reports that can be used to notify distribution maintainers of any changes to distributions.
Link to tracking Issue:
Fixes #28628