Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] use distributions.yaml in mdatagen #29851

Closed

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 13, 2023

Description:
Use the distributions.yaml introduced by #29697 to get the list of distributions.

@atoulme atoulme requested a review from a team December 13, 2023 03:21
@github-actions github-actions bot added the cmd/mdatagen mdatagen command label Dec 13, 2023
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: statusdata.go:14:12: pattern .distributions.yaml: no matching files found

.gitignore Outdated Show resolved Hide resolved
@atoulme atoulme force-pushed the use_distributions_yaml_in_mdatagen branch from 7f4e30e to 8967e9c Compare December 18, 2023 18:52
@bogdandrutu
Copy link
Member

bogdandrutu commented Dec 18, 2023

Also I am confused about the intent of the PR in general, why not using githubgen for this? Can you please clarify why we need this feature.

.gitignore Outdated Show resolved Hide resolved
@atoulme
Copy link
Contributor Author

atoulme commented Dec 18, 2023

Also I am confused about the intent of the PR in general, why not using githubgen for this? Can you please clarify why we need this feature.

We use the list of distributions to render the list with hyperlinks in the README of components presently.
We have moved the list of distributions to a centralized yaml file at the root of the repository, which is used to generate a distribution report under report/distributions.

This closes the loop on the change, by adopting the distribution data from the yaml file as the source of truth for component distributions. This allows us to maintain distributions by editing distributions.yaml and see it reflected in all READMEs and distribution reports. See #29697 for context and #28628 for the original motivation.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 2, 2024
@atoulme atoulme removed the Stale label Jan 2, 2024
@atoulme
Copy link
Contributor Author

atoulme commented Jan 4, 2024

@dmitryax please review as codeowner?

@dmitryax
Copy link
Member

dmitryax commented Jan 4, 2024

How this change will play with the fact that mdatagen is moved to core? I think we need to start planning the deprecation and removal of this package from contrib

@atoulme
Copy link
Contributor Author

atoulme commented Jan 4, 2024

you tell me :)

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 19, 2024
Copy link
Contributor

github-actions bot commented Feb 3, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/mdatagen mdatagen command Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants